Bug 2026722

Summary:	IP configuration is lost in Windows machines after upgrading the virtio-win drivers
Product:	Red Hat Enterprise Linux 9	Reporter:	Juan Orti <jortialc>
Component:	virtio-win	Assignee:	Vadim Rozenfeld <vrozenfe>
virtio-win sub component:	distribution	QA Contact:	Wenkang Ji <wji>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	unspecified	CC:	coli, germano, gveitmic, jinzhao, juzhang, leidwang, mdean, phou, qizhu, vrozenfe, wji, ymankad
Version:	9.2	Keywords:	Reopened, RFE, Triaged
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Windows
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-11-07 08:29:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Juan Orti 2021-11-25 15:39:59 UTC

Description of problem:
In bug 1898985 the documentation for upgrading the virtio-win drivers was updated to recommend using Windows update or using "netsh dump" to save the network configuration and then restore it.

This is risky or not feasible for several reasons:

- Windows update only works for Windows 2019. Older versions like 2016 are not getting the drivers.
- netsh dump poses some risk for VMs with multiple NICs for iSCSI, Windows clustering, backup etc.
- Dump transfer via netsh is not identical (this is problem of the netsh utility).
- netsh method is a potencial risky operation when you have to update hundreds of production VMs.

Version-Release number of selected component (if applicable):
virtio-win-1.9.19-1.el8.noarch

How reproducible:
Always

Steps to Reproduce:
1. Have Windows VM with static IP and an old version of virtio-win.
2. Run the installer virtio-win-guest-tools.exe

Actual results:
IP configuration is lost.

Expected results:
IP configuration preserved and drivers and qemu-ga updated.

Additional info:
We have seen that if you first update the NIC drivers and then run the installer, the IP configuration is preserved.

So the proposal for this bug is to modify the installer so it performs these steps in order:

1. Update NIC driver.
2. Remove old versions of the agent.
3. Upgrade everything else.

Comment 1 leidwang@redhat.com 2021-11-26 03:07:08 UTC

Hi Vadim,

I found two related bugs.The current solution is to warn users when they want to remove or upgrade the driver.
But currently bz2005220 has not been fixed.So we can not recive any warning now.
So is this bug a duplicate of 2005220?

https://bugzilla.redhat.com/show_bug.cgi?id=1965552
https://bugzilla.redhat.com/show_bug.cgi?id=2005220

Comment 2 Vadim Rozenfeld 2021-11-26 09:14:59 UTC

(In reply to leidwang from comment #1)
> Hi Vadim,
> 
> I found two related bugs.The current solution is to warn users when they
> want to remove or upgrade the driver.
> But currently bz2005220 has not been fixed.So we can not recive any warning
> now.
> So is this bug a duplicate of 2005220?
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1965552
> https://bugzilla.redhat.com/show_bug.cgi?id=2005220

Well, technically the problem with warning the user needed to be split
into two different parts :
- .msi (https://bugzilla.redhat.com/show_bug.cgi?id=1965552) - FIXED
- and the bundler (.exe) https://bugzilla.redhat.com/show_bug.cgi?id=2005220 - this problem is a way more complicated than .msi and is not fixed yet.

All the best,
Vadim.

Comment 3 leidwang@redhat.com 2022-01-04 02:49:45 UTC

According to comment2,close this bz as duplicate of bz2005220. 
Please reopen it if I misunderstood something.

*** This bug has been marked as a duplicate of bug 2005220 ***

Comment 7 leidwang@redhat.com 2022-02-08 03:09:39 UTC

The bug reproducer is the same as https://bugzilla.redhat.com/show_bug.cgi?id=2005220, so I set qa_ack to +. Thanks!

Comment 22 Peixiu Hou 2023-07-13 01:34:09 UTC

Hi Vadim,

Do we have any progress for this bug? It's ITR is 9.3.0~

Thanks~
Peixiu

Comment 23 Vadim Rozenfeld 2023-07-13 01:41:51 UTC

(In reply to Peixiu Hou from comment #22)
> Hi Vadim,
> 
> Do we have any progress for this bug? It's ITR is 9.3.0~
> 
> Thanks~
> Peixiu

Hi Peixiu,
It is an installer related issue. I'm going to start working on it 
after virtio-win drivers code freeze. 

Best,
Vadim.

Comment 24 Peixiu Hou 2023-07-13 06:43:23 UTC

(In reply to Vadim Rozenfeld from comment #23)
> (In reply to Peixiu Hou from comment #22)
> > Hi Vadim,
> > 
> > Do we have any progress for this bug? It's ITR is 9.3.0~
> > 
> > Thanks~
> > Peixiu
> 
> Hi Peixiu,
> It is an installer related issue. I'm going to start working on it 
> after virtio-win drivers code freeze. 
> 

ok, thanks~

> Best,
> Vadim.

Comment 29 Vadim Rozenfeld 2023-08-21 06:21:23 UTC

the static ip backup/restoring functionally has been implemented. If other settings like DHCP, DNS, WINS or even storage related settings need to be preserved and restored during the virtio-win drivers update, then please open a new bug/jira issue with the exact list of parameters.

Best,
Vadim.

Comment 30 Qianqian Zhu 2023-08-22 05:43:16 UTC

Hi Germano and Juan,

We suppose that keeping IP configurations would be sufficient to fix this bz, would you please help check the above comment 29 and confirm if there is other requirement from customer side? Thanks.

Comment 42 errata-xmlrpc 2023-11-07 08:29:32 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (virtio-win bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:6388