Bug 2026941

Summary:	python-lxml %check section runs 0 tests, which is treated as success
Product:	Red Hat Enterprise Linux 9	Reporter:	Miro Hrončok <mhroncok>
Component:	python-lxml	Assignee:	Python Maintainers <python-maint>
Status:	CLOSED ERRATA	QA Contact:	Lukáš Zachar <lzachar>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	9.0	CC:	pviktori, torsava
Target Milestone:	rc	Flags:	pm-rhel: mirror+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	python-lxml-4.6.3-5.el9	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-05-17 13:12:57 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Miro Hrončok 2021-11-26 14:47:06 UTC

Description of problem:
The latest build of python-lxml has:

Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.MiM182
+ umask 022
+ cd /builddir/build/BUILD
+ cd lxml-4.6.3
+ /usr/bin/python3 setup.py test
Building lxml version 4.6.3.
Building without Cython.
Building against libxml2 2.9.12 and libxslt 1.1.34
running test
running egg_info
WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.
writing src/lxml.egg-info/PKG-INFO
writing dependency_links to src/lxml.egg-info/dependency_links.txt
writing requirements to src/lxml.egg-info/requires.txt
writing top-level names to src/lxml.egg-info/top_level.txt
reading manifest file 'src/lxml.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'src/lxml.egg-info/SOURCES.txt'
running build_ext
building 'lxml.etree' extension
gcc ...
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
+ RPM_EC=0

This is dangerous. We better run the tests or remove the %check section.


Version-Release number of selected component:
python-lxml-4.6.3-3.el9

Steps to Reproduce: Build the pacakge.

Actual results:
Ran 0 tests in 0.000s, OK

Expected results:
Tests do run.

Additional info:
I am working on a Fedora fix, as the Fedora package is also affected.

Comment 1 Miro Hrončok 2021-11-26 15:24:42 UTC

Fedora fix included in https://src.fedoraproject.org/rpms/python-lxml/pull-request/11 -- unfortunately not all tests pass :(

Comment 2 Miro Hrončok 2021-11-26 15:45:06 UTC

https://gitlab.com/redhat/centos-stream/rpms/python-lxml/-/merge_requests/5

Comment 4 Miro Hrončok 2021-12-01 10:37:45 UTC

This has been fixed. It has passed gating.

Comment 5 Miro Hrončok 2021-12-01 10:41:00 UTC

I have checked the build logs in brew on all architectures. The %check section looks like this on all of them (not an exact match obviously):

Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.QROPuy
+ umask 022
+ cd /builddir/build/BUILD
+ cd lxml-4.6.3
+ cp -a build/lib.linux-aarch64-3.9/lxml src/
+ /usr/bin/python3 test.py -vuf
.......................................................................ss...s............s...ss...........s......................................................................................................................................................................................................................................................................................................................................................................................ssss...ssssssssssssss...ssssssssssssss............................................................................................................................................................................................................................................................................................ssss....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................s.............s.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 1931 tests in 4.698s
OK
Skipping tests in lxml.cssselect - external cssselect package is not installed
Comparing with ElementTree 1.3.0
TESTED VERSION: 4.6.3
    Python:           sys.version_info(major=3, minor=9, micro=9, releaselevel='final', serial=0)
    lxml.etree:       (4, 6, 3, 0)
    libxml used:      (2, 9, 12)
    libxml compiled:  (2, 9, 12)
    libxslt used:     (1, 1, 34)
    libxslt compiled: (1, 1, 34)
    FS encoding:      utf-8
    Default encoding: utf-8
    Max Unicode:      1114111
+ RPM_EC=0

Hence I would add Verified:Tested, but it was me who shipped the change.

Comment 7 Tomas Orsava 2021-12-01 10:47:43 UTC

(In reply to Miro Hrončok from comment #5)
> I have checked the build logs in brew on all architectures. The %check
> section looks like this on all of them (not an exact match obviously):
> 
> Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.QROPuy
> + umask 022
> + cd /builddir/build/BUILD
> + cd lxml-4.6.3
> + cp -a build/lib.linux-aarch64-3.9/lxml src/
> + /usr/bin/python3 test.py -vuf
> .......................................................................ss...
> s............s...ss...........s..............................................
> .............................................................................
> .............................................................................
> .............................................................................
> .............................................................................
> ....................ssss...ssssssssssssss...ssssssssssssss...................
> .............................................................................
> .............................................................................
> .............................................................................
> ..................................ssss.......................................
> .............................................................................
> .............................................................................
> .............................................................................
> .............................................................................
> .............................................................................
> ............................................................................
> s.............s..............................................................
> .............................................................................
> .............................................................................
> .............................................................................
> .............................................................................
> .............................................................................
> .............................................................................
> .............................................................................
> ........................................
> ----------------------------------------------------------------------
> Ran 1931 tests in 4.698s
> OK
> Skipping tests in lxml.cssselect - external cssselect package is not
> installed
> Comparing with ElementTree 1.3.0
> TESTED VERSION: 4.6.3
>     Python:           sys.version_info(major=3, minor=9, micro=9,
> releaselevel='final', serial=0)
>     lxml.etree:       (4, 6, 3, 0)
>     libxml used:      (2, 9, 12)
>     libxml compiled:  (2, 9, 12)
>     libxslt used:     (1, 1, 34)
>     libxslt compiled: (1, 1, 34)
>     FS encoding:      utf-8
>     Default encoding: utf-8
>     Max Unicode:      1114111
> + RPM_EC=0
> 
> Hence I would add Verified:Tested, but it was me who shipped the change.

Testing looks good, reported issue is fixed, setting Verified: Tested.

Comment 11 errata-xmlrpc 2022-05-17 13:12:57 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: python-lxml), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2476