Bug 2028024

Summary:	After deleting a SpecialResource, the node is still tagged although the driver is removed
Product:	OpenShift Container Platform	Reporter:	Udi Kalifon <ukalifon>
Component:	Special Resource Operator	Assignee:	yevgeny shnaidman <yshnaidm>
Status:	CLOSED ERRATA	QA Contact:	Udi Kalifon <ukalifon>
Severity:	high	Docs Contact:
Priority:	high
Version:	4.9	CC:	aos-bugs, bthurber, calfonso, carangog
Target Milestone:	---	Keywords:	Reopened
Target Release:	4.10.0	Flags:	bthurber: needinfo-
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-03-10 16:31:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Udi Kalifon 2021-12-01 10:44:34 UTC

Description of problem:
When deleting a SpecialResource - the DaemonSet and the driver's pod are removed, but the node labels are not updated that the capability is removed.


Version-Release number of selected component (if applicable):
OCP 4.9.4


How reproducible:
100%


Steps to Reproduce:
1. In a cluster with SRO and NFD, deploy the simple-kmod SpecialResource according to https://docs.openshift.com/container-platform/4.9/hardware_enablement/psap-special-resource-operator.html#deploy-simple-kmod-using-configmap-chart

2. See that the nodes get the labels:
specialresource.openshift.io/state-simple-kmod-0000=Ready
specialresource.openshift.io/state-simple-kmod-1000=Ready

3. Also see that there is a DaemonSet and a pod for the driver in the simple-kmod namespace

4. Delete the SpecialResource: oc delete specialresource/simple-kmod


Actual results:
The DaemonSet and the pod(s) are gone, but the node(s) still carry the labels even though they would not have this capability now.


Expected results:
The labels that NFD added should also be removed

Comment 2 Carlos Eduardo Arango Gutierrez 2022-01-28 14:14:09 UTC

You need to manually delete the node labels, or set a finalizer on SRO to do so

Comment 3 Walid A. 2022-01-28 14:18:10 UTC

@bthurber @Udi this is not a bug on NFD, please see Comment 2.  Please close this BZ.  thanks

Comment 4 yevgeny shnaidman 2022-01-28 17:44:20 UTC

This issue was actually a bug , and it was fixed by https://issues.redhat.com/browse/MGMT-8394

Comment 5 Walid A. 2022-01-28 20:44:26 UTC

Is there a PR associated with the fix that we can add to this BZ ?

Comment 8 errata-xmlrpc 2022-03-10 16:31:07 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056