Bug 2028285

Summary:	tracer hangs forever if not ran via tty
Product:	Red Hat Satellite	Reporter:	jcallaha
Component:	katello-tracer	Assignee:	satellite6-bugs <satellite6-bugs>
Status:	CLOSED MIGRATED	QA Contact:	Sam Bible <sbible>
Severity:	medium	Docs Contact:
Priority:	high
Version:	6.10.1	CC:	chrobert, iballou, jkadlcik, lufu, paji, rlavi, sbible, zhunting
Target Milestone:	stream	Keywords:	AutomationBlocker, MigratedToJIRA, TestBlocker, Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	Tracer 1.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-06-06 02:17:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description jcallaha 2021-12-01 22:04:14 UTC

Description of problem:
tracer performs a check to see if it can expect additional input from stdin, if so then it tries to read from stdin
https://github.com/FrostyX/tracer/blob/master/tracer/main.py#L42
However, this conditional also triggers if you run tracer via a non-tty ssh method. tracer then hangs on the blocking read until the session is killed.

Version-Release number of selected component (if applicable):
All versions. This part of the codebase has been intact for at least 7 years.

How reproducible:
100%

Steps to Reproduce:
1. Install tracer on a host
2. ssh root@<your host> tracer

Actual results:
The ssh command will continue to wait until killed (or timed out by other means)

Expected results:
tracer runs as normal (with a better mechanism of checking the stdin buffer)

Additional info:
os.isatty(0) also has the same issue

Comment 2 Brad Buckingham 2023-07-21 21:06:39 UTC

Upon review of our valid but aging backlog the Satellite Team has concluded that this Bugzilla does not meet the criteria for a resolution in the near term, and are planning to close in a month. This message may be a repeat of a previous update and the bug is again being considered to be closed. If you have any concerns about this, please contact your Red Hat Account team.  Thank you.

Comment 3 Jakub Kadlčík 2023-08-18 12:08:57 UTC

I am sorry, I must have missed the issue somehow :-/

I am proposing this upstream PR
https://github.com/FrostyX/tracer/pull/201

Comment 4 Brad Buckingham 2023-09-01 20:42:10 UTC

Jakub,

Thanks for submitting the upstream PR.

I'll update this so that it doesn't go through auto-closure.

Partha,

Can you have the katello team help with the review/verification of the upstream PR so that we may get incorporated in an upcoming Satellite release?

Thanks!

Comment 6 Ian Ballou 2024-01-16 16:15:44 UTC

We need to set this to modified and note which version of tracer receives https://github.com/FrostyX/tracer/pull/201

Comment 7 Eric Helms 2024-06-06 02:17:21 UTC

This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "SAT-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.