Bug 2028823

Summary: assertion failed at parse_ova.ml when ova directory ends with '/'
Product: Red Hat Enterprise Linux 8 Reporter: Vera <vwu>
Component: virt-v2vAssignee: Richard W.M. Jones <rjones>
Status: CLOSED ERRATA QA Contact: Vera <vwu>
Severity: medium Docs Contact:
Priority: medium    
Version: 8.6CC: chhu, juzhou, kkiwi, mxie, rjones, tyan, tzheng, vwu, xiaodwan
Target Milestone: rcKeywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: virt-v2v-1.42.0-19.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1964324 Environment:
Last Closed: 2022-11-08 09:18:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1964324    
Bug Blocks:    

Description Vera 2021-12-03 13:32:12 UTC 
+++ This bug was initially created as a clone of Bug #1964324 +++

Description of problem:
assertion failed at parse_ova.ml when ova directory ends with '/'

Version-Release number of selected component (if applicable):
virt-v2v-1.42.0-18.module+el8.6.0+13447+4b5d0856.x86_64

How reproducible:
100%

Steps to Reproduce:
# LIBGUESTFS_BACKEND=direct virt-v2v -i ova esx6_7-rhel8.3-x86_64/ -o null -v -x
virt-v2v: virt-v2v 1.42.0rhel=8,release=18.module+el8.6.0+13447+4b5d0856 (x86_64)
libvirt version: 7.9.0
[   0.0] Opening the source -i ova esx6_7-rhel8.3-x86_64/
libguestfs: trace: set_verbose true
libguestfs: trace: set_verbose = 0
libguestfs: trace: get_backend
libguestfs: trace: get_backend = "direct"
ova: processing manifest file /var/lib/libvirt/images/v2v/ova-images/esx6_7-rhel8.3-x86_64/esx6_7-rhel8.3-x86_64.mf
virt-v2v: error: internal error: assertion failed at parse_ova.ml, line 
273, char 15
rm -rf '/var/tmp/null.8nR2SO'
libguestfs: trace: close
libguestfs: closing guestfs handle 0x55e381a7c830 (state 0)


Actual results:
As the description in steps.

Expected results:
v2v runs the command successfully.

Additional info:
The command could run successfully after removing the '/' at the end.
Comment 3 Richard W.M. Jones 2022-04-26 12:36:39 UTC 
Fixed upstream in:
a00ce662cb33c33706a013ff98ff89244cd14667
f8428f5eaaff6dedc54a40138f760298a7a3a965
Comment 6 Vera 2022-05-10 06:57:45 UTC 
Verified with virt-v2v-1.42.0-19.module+el8.7.0+15006+42c9ed21.x86_64

Step：
# LIBGUESTFS_BACKEND=direct virt-v2v -i ova esx6_7-rhel8.3-x86_64/ -o null
[   0.0] Opening the source -i ova esx6_7-rhel8.3-x86_64/
[ 126.0] Creating an overlay to protect the source from being modified
[ 126.0] Opening the overlay
[ 131.1] Inspecting the overlay
[ 158.0] Checking for sufficient free disk space in the guest
[ 158.0] Estimating space required on target for each disk
[ 158.0] Converting Red Hat Enterprise Linux 8.3 (Ootpa) to run on KVM
virt-v2v: This guest has virtio drivers installed.
[ 293.4] Mapping filesystem data to avoid copying unused and blank areas
[ 294.2] Closing the overlay
[ 294.3] Assigning disks to buses
[ 294.3] Checking if the guest needs BIOS or UEFI to boot
[ 294.3] Initializing the target -o null
[ 294.3] Copying disk 1/1 to qemu URI json:{ "file.driver": "null-co", "file.size": "1E" } (raw)
    (100.00/100%)
[ 403.5] Creating output metadata
[ 403.5] Finishing off

Moving to Verified.
Comment 8 errata-xmlrpc 2022-11-08 09:18:32 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Low: virt:rhel and virt-devel:rhel security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:7472