Bug 2028899

Summary:	Review Request: rust-tree-sitter-loader - Locates, builds, and loads tree-sitter grammars at runtime
Product:	[Fedora] Fedora	Reporter:	Aleksei Bavshin <alebastr89>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rust-tree-sitter-loader-0.20.0-1.fc37	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-03-10 05:43:49 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2028895, 2028896, 2028897
Bug Blocks:	2028900

Description Aleksei Bavshin 2021-12-03 17:11:37 UTC

Spec URL: https://alebastr.fedorapeople.org/review/tree-sitter-cli/rust-tree-sitter-loader.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/alebastr/rust-tree-sitter-cli/fedora-rawhide-x86_64/03540349-rust-tree-sitter-loader/rust-tree-sitter-loader-0.20.0-1.fc37.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/alebastr/rust-tree-sitter-cli/build/3540349/
Description:
Locates, builds, and loads tree-sitter grammars at runtime

Fedora Account System Username: alebastr
Note: generated with `rust2rpm -a`; added upstream license file as required by the MIT license

Comment 1 Fabio Valentini 2022-03-09 15:15:34 UTC

You seem to have updated the spec file or SRPM, but not both, please reconcile those changes before importing the package:

Diff spec file in url and in SRPM
---------------------------------
--- /home/deca/Downloads/2028899-rust-tree-sitter-loader/srpm/rust-tree-sitter-loader.spec	2022-03-09 15:59:42.961643210 +0100
+++ /home/deca/Downloads/2028899-rust-tree-sitter-loader/srpm-unpacked/rust-tree-sitter-loader.spec	2022-02-23 07:55:08.000000000 +0100
@@ -14,5 +14,5 @@
 URL:            https://crates.io/crates/tree-sitter-loader
 Source:         %{crates_source}
-# Upstream license file - tree-sitter/tree-sitter#1520
+# Upstream license file
 Source1:        https://github.com/tree-sitter/tree-sitter/raw/v%{version}/LICENSE#/LICENSE.upstream

Other than that, looks good to me.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass (there are no tests)
- latest compatible version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 2 Gwyn Ciesla 2022-03-09 15:57:59 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tree-sitter-loader