Bug 202908
Summary: | Review Request: perl-POE-Component-Server-XMLRPC - Publish POE event handlers via XMLRPC over HTTP | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://search.cpan.org/dist/POE-Component-Server-XMLRPC/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-08-18 16:05:00 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 202905 | ||
Bug Blocks: | 163779 |
Description
Chris Weyl
2006-08-16 23:58:17 UTC
You might want to take out that commented "BR: perl(" line, but other than that it's another clean cpanspec-generated package. * source files match upstream: 263fd98df07331d64be5beb75b07835a POE-Component-Server-XMLRPC-0.05.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane: perl(POE::Component::Server::XMLRPC) = 0.05 perl(XMLRPCTransaction) perl-POE-Component-Server-XMLRPC = 0.05-1.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(POE) perl(POE::Component::Server::HTTP) perl(XMLRPC::Lite) perl(strict) perl(vars) perl(warnings) * %check is present and the single test passes: All tests successful. Files=1, Tests=1, 0 wallclock secs ( 0.13 cusr + 0.04 csys = 0.17 CPU) * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. APPROVED +Import to CVS +Add to owners.list +Bump release, build for devel +devel build succeeds +Request branching (FC-5) +Close bug Thanks for the review! |