Bug 2029096

Summary: pyanaconda.modules.common.errors.installation.StorageInstallationError: label failed
Product: [Fedora] Fedora Reporter: khrbrt
Component: blivet-guiAssignee: Vojtech Trefny <vtrefny>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 34CC: anaconda-maint-list, blivet-maint-list, dlehman, japokorn, jonathan, kellin, mkolman, rvykydal, vanmeeuwen+fedora, vponcova, vtrefny, w
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard: abrt_hash:2bce4f61c203d1fd659f29b01cb2033bfb14bb1fe051115f0b29330250ea67f9;VARIANT_ID=xfce;
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-06-08 01:05:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
File: anaconda-tb
none
File: anaconda.log
none
File: dbus.log
none
File: environ
none
File: journalctl
none
File: lsblk_output
none
File: lvm.log
none
File: nmcli_dev_list
none
File: os_info
none
File: program.log
none
File: storage.log none

Description khrbrt 2021-12-04 23:29:07 UTC
Description of problem:
I am installing Fedora to a new machine with one blank SSD and an NTFS HDD. 
I set an ext4 boot partion with label 'boot', an ext4 root partition labeled 'fedora' (or maybe 'root'? I'm already forgetting), and a swap partition labeled 'swap'. 
I also set to change the NTFS label to 'data01'. 
When I run the installer, I get a popup error for "cannot set label" (not exact wording), then the popup for Unknown Error that led to this dialog.  

Version-Release number of selected component:
anaconda-core-34.24.9-1.fc34.x86_64

The following was filed automatically by anaconda:
anaconda 34.24.9 exception report
Traceback (most recent call first):
  File "/usr/lib/python3.9/site-packages/dasbus/client/handler.py", line 497, in _handle_method_error
    raise exception from None
  File "/usr/lib/python3.9/site-packages/dasbus/client/handler.py", line 477, in _get_method_reply
    return self._handle_method_error(error)
  File "/usr/lib/python3.9/site-packages/dasbus/client/handler.py", line 444, in _call_method
    return self._get_method_reply(
  File "/usr/lib64/python3.9/site-packages/pyanaconda/modules/common/task/__init__.py", line 46, in sync_run_task
    task_proxy.Finish()
  File "/usr/lib64/python3.9/site-packages/pyanaconda/installation_tasks.py", line 527, in run_task
    sync_run_task(self._task_proxy)
  File "/usr/lib64/python3.9/site-packages/pyanaconda/installation_tasks.py", line 496, in start
    self.run_task()
  File "/usr/lib64/python3.9/site-packages/pyanaconda/installation_tasks.py", line 311, in start
    item.start()
  File "/usr/lib64/python3.9/site-packages/pyanaconda/installation_tasks.py", line 311, in start
    item.start()
  File "/usr/lib64/python3.9/site-packages/pyanaconda/installation_tasks.py", line 311, in start
    item.start()
  File "/usr/lib64/python3.9/site-packages/pyanaconda/installation.py", line 372, in run_installation
    queue.start()
  File "/usr/lib64/python3.9/threading.py", line 892, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/lib64/python3.9/site-packages/pyanaconda/threading.py", line 275, in run
    threading.Thread.run(self)
pyanaconda.modules.common.errors.installation.StorageInstallationError: label failed

Additional info:
addons:         com_redhat_kdump
cmdline:        /usr/bin/python3  /sbin/anaconda --liveinst --graphical
cmdline_file:   BOOT_IMAGE=vmlinuz initrd=initrd.img root=live:CDLABEL=Fedora-Xfce-Live-34-1-2  rd.live.image rd.live.check quiet
dnf.librepo.log: 
executable:     /sbin/anaconda
hashmarkername: anaconda
kernel:         5.11.12-300.fc34.x86_64
other involved packages: python3-dasbus-1.4-3.fc34.noarch, python3-libs-3.9.2-1.fc34.x86_64
product:        Fedora
release:        Fedora release 34 (Thirty Four)
type:           anaconda
version:        34

Comment 1 khrbrt 2021-12-04 23:29:10 UTC
Created attachment 1844731 [details]
File: anaconda-tb

Comment 2 khrbrt 2021-12-04 23:29:11 UTC
Created attachment 1844732 [details]
File: anaconda.log

Comment 3 khrbrt 2021-12-04 23:29:12 UTC
Created attachment 1844733 [details]
File: dbus.log

Comment 4 khrbrt 2021-12-04 23:29:13 UTC
Created attachment 1844734 [details]
File: environ

Comment 5 khrbrt 2021-12-04 23:29:14 UTC
Created attachment 1844735 [details]
File: journalctl

Comment 6 khrbrt 2021-12-04 23:29:15 UTC
Created attachment 1844736 [details]
File: lsblk_output

Comment 7 khrbrt 2021-12-04 23:29:16 UTC
Created attachment 1844737 [details]
File: lvm.log

Comment 8 khrbrt 2021-12-04 23:29:17 UTC
Created attachment 1844738 [details]
File: nmcli_dev_list

Comment 9 khrbrt 2021-12-04 23:29:18 UTC
Created attachment 1844739 [details]
File: os_info

Comment 10 khrbrt 2021-12-04 23:29:19 UTC
Created attachment 1844740 [details]
File: program.log

Comment 11 khrbrt 2021-12-04 23:29:21 UTC
Created attachment 1844741 [details]
File: storage.log

Comment 12 Vendula Poncova 2022-01-12 18:35:20 UTC
From storage.log:

INFO:blivet:executing action: [269] configure format ntfs filesystem mounted at /mnt/data01 on partition sdb2 (id 34)
INFO:program:Running... ntfslabel /dev/sdb2 data01
INFO:program:stderr:
INFO:program:b'The disk contains an unclean file system (0, 0).'
INFO:program:b'Metadata kept in Windows cache, refused to mount.'
INFO:program:b"Failed to mount '/dev/sdb2': Operation not permitted"
INFO:program:b'The NTFS partition is hibernated. Please resume Windows and turned it '
INFO:program:b'off properly, so mounting could be done safely.'
DEBUG:program:Return code: 1
ERROR:anaconda.modules.storage.installation:Failed to create storage layout: label failed
Traceback (most recent call last):
  File "/usr/lib64/python3.9/site-packages/pyanaconda/modules/storage/installation.py", line 82, in run
    self._turn_on_filesystems(
  File "/usr/lib64/python3.9/site-packages/pyanaconda/modules/storage/installation.py", line 162, in _turn_on_filesystems
    storage.do_it(callbacks)
  File "/usr/lib/python3.9/site-packages/blivet/threads.py", line 53, in run_with_lock
    return m(*args, **kwargs)
  File "/usr/lib/python3.9/site-packages/blivet/blivet.py", line 115, in do_it
    self.devicetree.actions.process(callbacks=callbacks, devices=self.devices)
  File "/usr/lib/python3.9/site-packages/blivet/actionlist.py", line 48, in wrapped_func
    return func(obj, *args, **kwargs)
  File "/usr/lib/python3.9/site-packages/blivet/actionlist.py", line 327, in process
    action.execute(callbacks)
  File "/usr/lib/python3.9/site-packages/blivet/threads.py", line 53, in run_with_lock
    return m(*args, **kwargs)
  File "/usr/lib/python3.9/site-packages/blivet/deviceaction.py", line 1110, in execute
    self._execute(dry_run=False)
  File "/usr/lib/python3.9/site-packages/blivet/threads.py", line 53, in run_with_lock
    return m(*args, **kwargs)
  File "/usr/lib/python3.9/site-packages/blivet/formats/fs.py", line 664, in write_label
    self._writelabel.do_task()
  File "/usr/lib/python3.9/site-packages/blivet/tasks/fswritelabel.py", line 61, in do_task
    raise FSWriteLabelError("label failed")
blivet.errors.FSWriteLabelError: label failed


It looks like this message might help you with your issue: "The NTFS partition is hibernated. Please resume Windows and turned it off properly, so mounting could be done safely." It would be great if our storage library could propagate the message to the installer. Reassigning to blivet.

Comment 13 Vojtech Trefny 2022-01-27 15:16:57 UTC
I'm moving this to blivet-gui which should allow you to change NTFS label if the filesystem is hibernated (because `ntfslabel` tries to mount the device first and it's not possible if Windows on the NTFS partition is hibernated). The question is whether it is even possible to detect this without actually trying to mount the device.

Comment 14 Ben Cotton 2022-05-12 16:41:39 UTC
This message is a reminder that Fedora Linux 34 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 34 on 2022-06-07.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '34'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 34 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 15 Ben Cotton 2022-06-08 01:05:54 UTC
Fedora Linux 34 entered end-of-life (EOL) status on 2022-06-07.

Fedora Linux 34 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release.

Thank you for reporting this bug and we are sorry it could not be fixed.