Bug 2029355

Summary: Rebase libtpms to at least 0.9.1 for 8.6
Product: Red Hat Enterprise Linux 8 Reporter: Marc-Andre Lureau <marcandre.lureau>
Component: libtpmsAssignee: Marc-Andre Lureau <marcandre.lureau>
Status: CLOSED ERRATA QA Contact: Qinghua Cheng <qcheng>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.6CC: coli, ddepaula, jinzhao, juzhang, qcheng, yanqzhan, yfu
Target Milestone: rcKeywords: Rebase, Triaged
Target Release: 8.6   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libtpms-0.9.1-0.20211126git1ff6fe1f43.module+el8.6.0+13725+61ae1949 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-05-10 13:24:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Marc-Andre Lureau 2021-12-06 09:58:49 UTC
Rebase libtpms to sync with rhel9 rhbz#2027951, and fix a number of issues and improvements:

version 0.9.0:
  - NOTE: Downgrade to previous versions is not possible. See below.
  - The size of the context gap has been adjusted to 0xffff from 0xff.
    As a consequence of this the volatile state's format (STATE_RESET_DATA)
    has changed and cannot be downgraded.
  - Applied work-around for Win 2016 & 2019 server related to
    TPM2_ContextLoad (issue #217)
  - Check for several more compile-time constants
  - Enabled Camellia symmetric key encryption algorithm
  - tpm2: CryptSym: fix AES output IV
  - tpm2: Added a cache for private exponent D and prime Q
  - tpm2: bug fixes related to state marshalling
  - tpm2: Consume padding bytes in TPM2_ContextLoad() (Win2k19, issue #217)
  - tests: Improvements on the fuzzer
  - tpm2: Switch to UINT16 for CONTEXT_SLOT and 64k context gap
  - tpm2: Update to TPM 2 spec rev 164
  - build-sys: Enable building --without-tpm1
  - tpm2: Marshal event sequence objects' hash state
  - tpm2: Fixes for build and runtime when using OpenSSL 3.0

version 0.8.0
  - NOTE: Downgrade to previous versions is not possible. See below.
  - Update to TPM 2 code release 159
    - X509 support is enabled
      - SM2 signing of ceritificates is NOT supported
    - Authenticated timers are disabled
  - Due to fixes in the TPM 2 prime number generation code in rev155 it is not
    possible to downgrade from libtpms version 0.8.0 to some previous version.
    The seeds are now associated with an age so that older seeds use the old
    TPM 2 prime number generation code while newer seed use the newer code.
  - Update to TPM 2 code release 162
    - ECC encryption / decryption is disabled
  - Fix support for elliptic curve due to missing unmarshalling code
  - Runtime filter supported elliptic curves supported by OpenSSL
  - Fix output buffer parameter and size for RSA decryption that could cause
    stack corruption under certain circumstances
  - Set the RSA PSS salt length to the digest length rather than max. possible
  - Fixes to symmetric decryption related to input size check,
    defer padding to the user [EVP_CIPHER_CTX_set_padding(ctx, 0)] and
    to always use a temporary malloc'ed buffer for decryption
  - Fixed the set of PCRs belonging to the TCB group. This affects the
    pcrUpdateCounter in TPM2_Pcrread() responses, thus needs latest `swtpm`
    for test cases to succeed there.

Comment 1 John Ferlan 2021-12-06 21:37:55 UTC
Moving to Marc-Andre since he is the maintainer (we probably need to fix the RHEL8 bugzilla components)

Comment 3 John Ferlan 2021-12-14 12:31:23 UTC
Can we get a qa_ack+ and ITM set please?

Comment 4 Qinghua Cheng 2021-12-21 04:13:33 UTC
Already set qa_ack+ and ITM, clear my needinfo flag.

Comment 11 Danilo de Paula 2022-01-10 05:50:40 UTC
This is not the right errata for the virt components in RHEL-8.6.

the right one is https://errata.devel.redhat.com/advisory/81310

If we remove it now, we need to move back to MODIFIED and it risk losing flags.
Can QE verify the change? We can then remove the BZ without changing its state (if it's in verified)

Comment 12 Yanan Fu 2022-01-10 06:20:33 UTC
Gating test with virt module 13725 pass, add 'Verified:Tested, SanityOnly'

Comment 17 errata-xmlrpc 2022-05-10 13:24:19 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: virt:rhel and virt-devel:rhel security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:1759