Bug 2029647

Summary: The flag Sys::Virt::NWFilterBinding::CREATE_VALIDATE does not work
Product: Red Hat Enterprise Linux 8 Reporter: yicui
Component: perl-Sys-VirtAssignee: Daniel Berrangé <berrange>
Status: CLOSED ERRATA QA Contact: yicui
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.6CC: berrange, dzheng, lmen, virt-maint, xuzhang
Target Milestone: rcKeywords: Triaged
Target Release: 8.6   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Sys-Virt-7.10.0-1.module+el8.6.0+13586+f7660a75 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-05-10 13:24:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description yicui 2021-12-07 01:02:08 UTC
Description of problem:
Unable to validate xml when creating nwfilter_binding with Sys::Virt::NWFilterBinding::CREATE_VALIDATE flag.

Version-Release number of selected component (if applicable):
perl-Sys-Virt-7.8.0-1.module+el8.6.0+13062+b4fa4cf3.x86_64
libvirt-7.9.0-1.module+el8.6.0+13150+28339563.x86_64
qemu-kvm-6.1.0-5.module+el8.6.0+13430+8fdd5f85.x86_64


How reproducible:
100%

Steps to Reproduce:
1.Run $conn->create_nwfilter_binding($err_xml, Sys::Virt::NWFilterBinding::CREATE_VALIDATE)

Or run below script:
================
# -*- perl -*-

use Sys::Virt;
my $conn = Sys::Virt->new();
my $err_xml= <<EOF;
  <filterbinding>
   <owner>
    <uuid>dd7949ca-ddcc-4f91-8808-e6e9844650e5</uuid>
   </owner>
   <portdev name='vnet1'/>
  </filterbinding>
EOF

my $res = $conn->create_nwfilter_binding($err_xml, Sys::Virt::NWFilterBinding::CREATE_VALIDATE);
================

Actual results:
The xml was not validated:
==
perl test.pl 
libvirt error code: 1, message: internal error: filter binding has no owner name


Expected results:
It should raise Sys::Virt::Error::ERR_INVALID_SCHEMA.

Additional info:
It works with below changes:
====================
# diff  /usr/lib64/perl5/vendor_perl/Sys/Virt/NWFilterBinding.pm /tmp/NWFilterBinding.pm 
52c52
< 	$self = Sys::Virt::NWFilterBinding::_create_xml($con,  $params{xml}, $params{flags});
---
> 	$self = Sys::Virt::NWFilterBinding::_create_xml($con,  $params{xml});

====================
# perl test.pl 
libvirt error code: 92, message: XML document failed to validate against schema: Unable to validate doc against /usr/share/libvirt/schemas/nwfilterbinding.rng
Expecting element name, got uuid
Element owner failed to validate content
Expecting an element mac, got nothing
Invalid sequence in interleave
Element filterbinding failed to validate content

Comment 1 Daniel Berrangé 2021-12-07 09:25:22 UTC
Fix posted to https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/48

Comment 2 John Ferlan 2021-12-07 19:01:45 UTC
Moving to RHEL 8.6 for resolution as there is no specific RHEL-AV product for 8.6.0

The flags are going to be messed up and will need to reset - especially qa_ack+

Comment 5 yicui 2021-12-17 05:49:40 UTC
Verified on perl-Sys-Virt-7.10.0-1.module+el8.6.0+13586+f7660a75.x86_64, it works well.
# perl test.pl 
libvirt error code: 92, message: XML document failed to validate against schema: Unable to validate doc against /usr/share/libvirt/schemas/nwfilterbinding.rng
Expecting element name, got uuid
Element owner failed to validate content
Expecting an element mac, got nothing
Invalid sequence in interleave
Element filterbinding failed to validate content

Comment 10 yicui 2022-01-06 01:04:22 UTC
Verified on perl-Sys-Virt-7.10.0-1.module+el8.6.0+13586+f7660a75.x86_64, pls check test results in https://bugzilla.redhat.com/show_bug.cgi?id=2029647#c5

Comment 12 errata-xmlrpc 2022-05-10 13:24:19 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: virt:rhel and virt-devel:rhel security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:1759