Bug 2030449

Summary:	dkms ldtarball doesn't work
Product:	[Fedora] Fedora EPEL	Reporter:	Jan Edler <jan.edler>
Component:	dkms	Assignee:	Tom Rix <trix>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	epel7	CC:	negativo17, trix
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	dkms-3.0.3-1.el9 dkms-3.0.3-1.el8 dkms-3.0.3-1.el8.next dkms-3.0.3-1.fc34 dkms-3.0.3-1.fc35 dkms-3.0.3-1.el9.next dkms-3.0.3-1.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-12-26 00:26:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jan Edler 2021-12-08 19:31:53 UTC

Description of problem:
dkms ldtarball doesn't work

Version-Release number of selected component (if applicable):
3.0.2-1.el7

How reproducible:
I haven't found a way for it to succeed.
Am I the only one?

Steps to Reproduce:
1. dkms mktarball
2. dkms ldtarball


Actual results:
No valid dkms.conf in dkms_source_tree or dkms_binaries_only.
/path/to/foo-3.10.0.dkms.tar.gz is not a valid DKMS tarball.

But the tarball created does have dkms.conf under dkms_binaries_only/

Expected results:
Loading tarball for foo-3.10.0
Loading /var/lib/dkms/foo/3.10.0/3.10.0-1160.el7.x86_64/x86_64...
Creating symlink /var/lib/dkms/foo/3.10.0/source -> /usr/src/foo-3.10.0


Additional info:
It seems to me that this stems from the lack of a "break"
after line 1811 in the load_tarball() function.
It's the same in github.

If I add that "break", it works for me.

I wasn't subscribed to the dkms-devel mailing list.
I have been trying to subscribe to report it there, but unable to subscribe so far.

Comment 1 Tom Rix 2021-12-11 17:41:06 UTC

Upstream fix
https://github.com/dell/dkms/pull/189

Comment 2 Fedora Update System 2021-12-17 07:54:02 UTC

FEDORA-2021-ff7390a25d has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-ff7390a25d

Comment 3 Fedora Update System 2021-12-17 07:54:02 UTC

FEDORA-2021-dffb9af88e has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-dffb9af88e

Comment 4 Fedora Update System 2021-12-17 07:54:03 UTC

FEDORA-EPEL-NEXT-2021-621b019f91 has been submitted as an update to Fedora EPEL 8 Next. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-NEXT-2021-621b019f91

Comment 5 Fedora Update System 2021-12-17 07:54:03 UTC

FEDORA-EPEL-2021-de957dee7c has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-de957dee7c

Comment 6 Fedora Update System 2021-12-17 07:54:03 UTC

FEDORA-EPEL-2021-8391cd1abf has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-8391cd1abf

Comment 7 Fedora Update System 2021-12-17 07:54:04 UTC

FEDORA-EPEL-NEXT-2021-10f7145d18 has been submitted as an update to Fedora EPEL 9 Next. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-NEXT-2021-10f7145d18

Comment 8 Fedora Update System 2021-12-17 07:54:05 UTC

FEDORA-EPEL-2021-d590025930 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-d590025930

Comment 9 Fedora Update System 2021-12-18 02:04:38 UTC

FEDORA-2021-dffb9af88e has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-dffb9af88e`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-dffb9af88e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2021-12-18 02:20:46 UTC

FEDORA-2021-ff7390a25d has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-ff7390a25d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-ff7390a25d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2021-12-18 02:22:12 UTC

FEDORA-EPEL-2021-de957dee7c has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-de957dee7c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2021-12-18 02:27:30 UTC

FEDORA-EPEL-2021-d590025930 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-d590025930

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2021-12-18 02:33:48 UTC

FEDORA-EPEL-NEXT-2021-621b019f91 has been pushed to the Fedora EPEL 8 Next testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-NEXT-2021-621b019f91

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2021-12-18 02:33:52 UTC

FEDORA-EPEL-NEXT-2021-10f7145d18 has been pushed to the Fedora EPEL 9 Next testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-NEXT-2021-10f7145d18

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2021-12-18 02:34:39 UTC

FEDORA-EPEL-2021-8391cd1abf has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-8391cd1abf

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2021-12-26 00:26:04 UTC

FEDORA-EPEL-2021-d590025930 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2021-12-26 00:49:52 UTC

FEDORA-EPEL-2021-de957dee7c has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2021-12-26 00:55:34 UTC

FEDORA-EPEL-NEXT-2021-621b019f91 has been pushed to the Fedora EPEL 8 Next stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2021-12-26 01:09:29 UTC

FEDORA-2021-dffb9af88e has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 20 Fedora Update System 2021-12-26 01:24:15 UTC

FEDORA-2021-ff7390a25d has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 21 Fedora Update System 2021-12-26 01:24:28 UTC

FEDORA-EPEL-NEXT-2021-10f7145d18 has been pushed to the Fedora EPEL 9 Next stable repository.
If problem still persists, please make note of it in this bug report.

Comment 22 Fedora Update System 2021-12-26 01:46:20 UTC

FEDORA-EPEL-2021-8391cd1abf has been pushed to the Fedora EPEL 7 stable repository.
If problem still persists, please make note of it in this bug report.