Bug 2030482

Summary:	abidiff: incorrect failure on efivar
Product:	Red Hat Enterprise Linux 9	Reporter:	Robbie Harwood <rharwood>
Component:	libabigail	Assignee:	Dodji Seketeli <dodji>
Status:	CLOSED ERRATA	QA Contact:	Michal Kolar <mkolar>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	dodji, mcermak, wcohen
Target Milestone:	rc	Keywords:	Triaged
Target Release:	---	Flags:	pm-rhel: mirror+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libabigail-2.3-1.el9	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-11-07 08:56:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2024374

Description Robbie Harwood 2021-12-08 22:15:42 UTC

On the git version of efivar ( https://github.com/rhboot/efivar , currently at c745bb55c185552e2042324ee9cbfc8ebd1786df ), if one runs the following:

dnf builddep efivar
make
make abicheck

It will result in a call like

abidiff \
	--suppr abignore \
	--headers-dir2 /builddir/build/BUILD/efivar-37/src/include/efivar/ \
	libefivar.abixml \
	libefivar.so

which fails with

Functions changes summary: 0 Removed, 1 Changed (42 filtered out), 0 Added functions
Variables changes summary: 0 Removed, 0 Changed (43 filtered out), 0 Added variables

1 function with some indirect sub-type change:

  [C] 'function int _efi_set_variable(efi_guid_t, const char*, uint8_t*, size_t, uint32_t)' at lib.c:33:1 has some indirect sub-type changes:
    parameter 1 of type 'typedef efi_guid_t' changed:
      underlying type 'struct efi_guid_t' at efivar-types.h:13:1 changed:
        type name changed from 'efi_guid_t' to '__anonymous_struct__6'
        type size hasn't changed
        no data member changes (5 filtered);

But only on RHEL 9.  It correctly passes on el8, as well as Fedoras 33-36.

Comment 5 Dodji Seketeli 2023-05-15 14:49:37 UTC

libabigail-2.3-1.el9 has been built for RHEL9 and fixes this issue.

Comment 8 Michal Kolar 2023-06-16 13:32:14 UTC

Verified with libabigail-2.3-1.el9.

Comment 13 errata-xmlrpc 2023-11-07 08:56:37 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (libabigail bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:6713