Bug 2030875

Summary:	Review Request: rust-psl-types - Common types for the public suffix implementation crates
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Davide Cavalca <davide>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	davide, package-review
Target Milestone:	---	Flags:	davide: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-01-05 23:18:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1938383

Description Fabio Valentini 2021-12-09 23:15:24 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-psl-types.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-psl-types-2.0.10-1.fc35.src.rpm

Description:
Common types for the public suffix implementation crates.

Fedora Account System Username: decathorpe

Comment 1 Davide Cavalca 2021-12-31 07:58:59 UTC

Taking this review

Comment 2 Davide Cavalca 2021-12-31 08:01:35 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT or ASL 2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 3 Fabio Valentini 2021-12-31 11:26:14 UTC

Thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/40337
https://pagure.io/releng/fedora-scm-requests/issue/40338
https://pagure.io/releng/fedora-scm-requests/issue/40339

Comment 4 Gwyn Ciesla 2022-01-04 15:21:17 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-psl-types

Comment 5 Fedora Update System 2022-01-05 23:18:29 UTC

FEDORA-2022-5c20aa4bcf has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.