Bug 2031155

Summary:	URL of maintained container disks changed
Product:	OpenShift Container Platform	Reporter:	Dominik Holler <dholler>
Component:	Console Kubevirt Plugin	Assignee:	Yaacov Zamir <yzamir>
Status:	CLOSED DUPLICATE	QA Contact:	Guohua Ouyang <gouyang>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.9	CC:	aos-bugs, gouyang, rmohr, tnisan, ycui, yzamir
Target Milestone:	---
Target Release:	4.10.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-01-10 10:46:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dominik Holler 2021-12-10 16:07:40 UTC

Description of problem:
There are maintained containerdisks in quay.io/containerdisks/ , which are perfectly suitable as examples in the UI.


Steps to Reproduce:
1. Create Virtual Machine from template
2. Choose Fedora 32+ VM / CentOS 7+ or CentOS 8+
3. Boot source type: Import via Regestry

Actual results:
centos8: Example: quay.io/kubevirt/centos8-container-disk-images:latest
centos7: Example: quay.io/kubevirt/centos8-container-disk-images:latest
fedora: Example: quay.io/kubevirt/fedora-cloud-container-disk-demo:latest

Expected results:
centos8: Example: quay.io/containerdisks/centos:8.4
centos7: Example: quay.io/containerdisks/centos:7-2009
fedora: Example: quay.io/containerdisks/fedora:35


Additional info:
https://github.com/kubevirt/containerdisks/

Comment 1 Guohua Ouyang 2021-12-13 01:23:12 UTC

I think we'd better to use the tag `latest` for all examples, otherwise we need to maintain the examples all the time.

Comment 2 Yaacov Zamir 2021-12-13 07:51:29 UTC

Wow, didn't know about quay.io/containerdisks cool project !

Comment 3 Dominik Holler 2021-12-13 08:01:54 UTC

(In reply to Guohua Ouyang from comment #1)
> I think we'd better to use the tag `latest` for all examples, otherwise we
> need to maintain the examples all the time.

In CentOS 7 and 8 there are not updates anymore expected, and for Fedora it is planed to update the URL, if we support a new Fedora version.

Comment 4 Roman Mohr 2021-12-13 08:10:07 UTC

(In reply to Dominik Holler from comment #3)
> (In reply to Guohua Ouyang from comment #1)
> > I think we'd better to use the tag `latest` for all examples, otherwise we
> > need to maintain the examples all the time.
> 
> In CentOS 7 and 8 there are not updates anymore expected, and for Fedora it
> is planed to update the URL, if we support a new Fedora version.

Also note that these tags

> centos8: Example: quay.io/containerdisks/centos:8.4
> centos7: Example: quay.io/containerdisks/centos:7-2009
> fedora: Example: quay.io/containerdisks/fedora:35

are kind of moving. So if the 8.4 centos image gets rebuilt from centos, then we recognize that and the tag changes. The same for fc:35.
The background for not using a moving `latest` tag is that one can get a completely different OS. Like you try out your app on the fc:latest tag which points to fc33, and it passes all tests. Then you move on and you suddenly end up with fc:35 later. So what we try to apply is a pattern of: For a given moving tag, you get an updated and CVE fixes inheriting version, but you don't get a fundamentally different OS. At least I believe that it should be a conscious decision of the consumer when one is ready to update.

Let me know if that does not make sense for you.

Comment 5 Yaacov Zamir 2021-12-13 08:25:41 UTC

Hi all
Can we add an annotation with "suggested download url" "suggested external registry container image url" ?

This way the template owner can set the suggested when CLI/UI show information about the template and suggest external resources/

Comment 6 Dominik Holler 2021-12-13 10:43:26 UTC

(In reply to Yaacov Zamir from comment #5)
> Hi all
> Can we add an annotation with "suggested download url" "suggested external
> registry container image url" ?
> 
> This way the template owner can set the suggested when CLI/UI show
> information about the template and suggest external resources/

Nice idea to move the information from UI to the templates.
Do you think this is achievable for 4.10, or should we postpone this idea to 4.11 ?

Comment 7 Yaacov Zamir 2021-12-13 11:19:26 UTC

> Do you think this is achievable for 4.10, or should we postpone this idea to 4.11 ?

The UI has feature freeze on 17 Dec, so we will not make it before feature freeze, but if we get the annotations in 4.10 we can start looking for the annotation and using it in the z stream

Comment 8 Dominik Holler 2021-12-13 11:25:31 UTC

> The UI has feature freeze on 17 Dec, so we will not make it before feature freeze, but if we get the annotations in 4.10 we can start looking for the annotation and using it in the z stream

Sounds good, may I create a bug to track adding the annotations to the templates, and UI updates the strings a last time manually in this bug?

Comment 9 Yaacov Zamir 2021-12-13 11:42:45 UTC

> Sounds good, may I create a bug to track adding the annotations to the templates, and UI updates the strings a last time manually in this bug?

I'm ok with this

Comment 10 Dominik Holler 2021-12-13 15:23:00 UTC

Bug #2031857 is going to track the required change in the templates.

Comment 11 Yaacov Zamir 2022-01-10 10:46:29 UTC


*** This bug has been marked as a duplicate of bug 2038832 ***