Bug 2031239

Spec URL: https://www.flyn.org/SRPMS/golang-github-bep-gowebp.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-bep-gowebp-0.1.0-1.fc35.src.rpm

Rebuilt using go2rpm.

I'm not able to build this one against rawhide. A test fails because swig is not installed:

> github.com/bep/gowebp/libwebp_src/swig
> go build github.com/bep/gowebp/libwebp_src/swig: swig: exec: "swig": executable file not found in $PATH

After adding it it fails with missing runtime.h

> github.com/bep/gowebp/libwebp_src/swig
> # github.com/bep/gowebp/libwebp_src/swig
> libwebp_gc.c:14:10: fatal error: runtime.h: No such file or directory
>    14 | #include "runtime.h"
>       |          ^~~~~~~~~~~
> compilation terminated.

I am trying to figure this out. The build on mock Rawhide deviates from the build on mock Fedora 35. Rawhide appears to run more tests and fails. Fedora 35 succeeds.



Rawhide:
      command: go test -buildmode pie -compiler gc -ldflags " -X github.com/bep/gowebp/version=0.1.0 -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 -Wl,-dT,/builddir/build/BUILD/gowebp-0.1.0/.package_note-golang-github-bep-gowebp-0.1.0-1.fc37.x86_64.ld '"
      testing: github.com/bep/gowebp
github.com/bep/gowebp/internal/libwebp
?   	github.com/bep/gowebp/internal/libwebp	[no test files]
github.com/bep/gowebp/libwebp
PASS
ok  	github.com/bep/gowebp/libwebp	0.491s
github.com/bep/gowebp/libwebp
PASS
ok  	github.com/bep/gowebp/libwebp	0.504s
github.com/bep/gowebp/libwebp/webpoptions
?   	github.com/bep/gowebp/libwebp/webpoptions	[no test files]
github.com/bep/gowebp/libwebp_src/swig
# github.com/bep/gowebp/libwebp_src/swig
libwebp_gc.c:14:10: fatal error: runtime.h: No such file or directory
   14 | #include "runtime.h"
      |          ^~~~~~~~~~~
compilation terminated.
error: Bad exit status from /var/tmp/rpm-tmp.ZNIJjQ (%check)
    Bad exit status from /var/tmp/rpm-tmp.ZNIJjQ (%check)




Fedora 35:
            command: go test -buildmode pie -compiler gc -ldflags " -X github.com/bep/gowebp/version=0.1.0 -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  '"
      testing: github.com/bep/gowebp
github.com/bep/gowebp/libwebp
PASS
ok  	github.com/bep/gowebp/libwebp	0.574s

I would like to share with you https://fale.fedorapeople.org/golang-github-bep-gowebp/golang-github-bep-gowebp.spec that is my take to this SPEC file. Maybe it can help with it.
As for that specific test, I've skipped it. My understanding is that it would be ok for the package even if the test fails

Spec URL: https://www.flyn.org/SRPMS/golang-github-bep-gowebp.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-bep-gowebp-0.1.0-1.fc35.src.rpm

Apply suggestions from Fabio.

go2rpm package, fedora-review is correct:

- The specfile is sane.
- License is correct
- Builds successfully in mock
- No rpmlint errors
- %check section passes
- The latest version is packaged
- The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- Add package to release-monitoring.org
- Add package to Koschei.
- Give go-sig privileges on package
- Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. (rhbz#BUG_ID)

Thanks!

PS: Due to the fact that rpmbuild does not care abou folders in the documentation, the last file (libwebp_src/swig/README) will replace libwebp_src/README. I would suggest renaming or dropping libwebp_src/swig/README.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-bep-gowebp

FEDORA-2022-34cc54bd63 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-34cc54bd63

FEDORA-2022-34cc54bd63 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2022-8700bb8fb1 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8700bb8fb1

FEDORA-2022-90631629ed has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-90631629ed

FEDORA-2022-8700bb8fb1 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-8700bb8fb1 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-8700bb8fb1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-90631629ed has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-90631629ed \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-90631629ed

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-90631629ed has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2022-8700bb8fb1 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.