Bug 2031370
| Summary: | Review Request: rit-meera-new-fonts - Open Type body text font for Malayalam traditional script | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rajeesh <rajeeshknambiar> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | gwync, package-review, panemade, vvijayra |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-12-31 07:44:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Rajeesh
2021-12-11 12:00:00 UTC
I prefer different bugzilla account for package reviews. Review Suggestion:
1) When new font packaging approved in Fedora, 'fontpackages' got obsoleted by 'fonts-rpm-macros' package. Hence, drop below from SPEC file
BuildRequires: fontpackages-devel
Requires: fontpackages-filesystem
2) Change below from
%global fontfamily meeranew
to
%global fontfamily Meera New
Font Family name is "Meera New" and not "MeeraNew". Please note <SPACE> character. Thus it makes packages name as rit-meera-new-fonts.
3) You should add config file path by correcting below line
%global fontconfs %{nil}
4) SPEC file shows
%global fontappstreams in.org.rachana.meeranew.metainfo.xml
fix this to
%global fontappstreams meta/in.org.rachana.meeranew.metainfo.xml
I think here upstream should actually use file name as in.org.rachana.meera-new.metainfo.xml. This is based on the way you named other font appstream file for " rit-rachana-fonts" in.org.rachana.rit-rachana.metainfo.xml where fontfamily is "RIT Rachana".
Submit new package SPEC and SRPM.
Thanks for the review comments, Parag! Addressed all the comments (and also released a new upstream version). Spec URL: https://rajeeshknambiar.fedorapeople.org/spec/rit-meera-new-fonts.spec SRPM URL: https://rajeeshknambiar.fedorapeople.org/srpm/rit-meera-new-fonts-1.2.1-0.fc35.src.rpm The only thing remaining here is that this new package is not obsoleting existing smc-meera-fonts package. Fix this by changing Obsoletes: smc-meera-fonts <= 7.0 to Obsoletes: smc-meera-fonts <= 7.0.3 Rest looks good to me. APPROVED. Thank you. A slight problem when I do `fedpkg request-repo` with updated name `rit-meera-new-fonts` not matching with bugzilla entry name (`meeranew`). Should I abandon this request and create another one? Sorry I forgot to tell here that the package name need to be updated. When you do request-repo then the package <name> need to be matched with this bug's title. I have corrected it. Please try again request-repo. One more thing I realized the fontconfig file contains font family name as "MeeraNew". Change it to "Meera New". (In reply to Parag AN(पराग) from comment #7) > One more thing I realized the fontconfig file contains font family name as > "MeeraNew". Change it to "Meera New". Yes, that is fixed in new upstream version. (In reply to Rajeesh from comment #8) > (In reply to Parag AN(पराग) from comment #7) > > One more thing I realized the fontconfig file contains font family name as > > "MeeraNew". Change it to "Meera New". > > Yes, that is fixed in new upstream version. Thanks @gwync I still cannot push to the repository as I'm not a member (see https://pagure.io/releng/fedora-scm-requests/issue/40013#comment-771409) Could you take a look? Transferred ownership. |