Bug 2031922

Summary:	Review Request: golang-github-jinzhu-copier - Copier for golang, copy value from struct to struct and more
Product:	[Fedora] Fedora	Reporter:	Brandon Perkins <bperkins>
Component:	Package Review	Assignee:	Maxwell G <maxwell>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mark.e.fuller, maxwell, package-review, zebob.m
Target Milestone:	---	Flags:	maxwell: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-07-15 07:27:31 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2074467, 2029628

Description Brandon Perkins 2021-12-13 17:23:15 UTC

Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-jinzhu-copier.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/7121/79937121/golang-github-jinzhu-copier-0.3.4-1.fc36.src.rpm
Description: Copier for golang, copy value from struct to struct and more.
Fedora Account System Username: bdperkin

Comment 1 Maxwell G 2022-01-30 18:13:36 UTC

Please package the latest version, 0.3.5.

Comment 2 Maxwell G 2022-01-30 22:11:09 UTC

Your SRPM link has expired; Koji deletes builds after a certain amount of time. Also, you should remove `%{?dist}` from the changelog. go2rpm had a bug that was recently fixed where it incorrectly added `%{?dist}` to the changelog.

Comment 3 Brandon Perkins 2022-01-31 16:10:00 UTC

Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-jinzhu-copier.spec
https://kojipkgs.fedoraproject.org//work/tasks/8432/82188432/golang-github-jinzhu-copier-0.3.5-1.fc36.src.rpm

Specified changes made.

Comment 4 Brandon Perkins 2022-01-31 16:14:17 UTC

Spec URL: https://raw.githubusercontent.com/bdperkin/haproxytech/master/SPECS/golang-github-jinzhu-copier.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/8432/82188432/golang-github-jinzhu-copier-0.3.5-1.fc36.src.rpm

Specified changes made.

Comment 5 Maxwell G 2022-02-27 04:13:53 UTC

It expired again, so I manually constructed one for fedora-review. Sorry for not getting to this sooner.

I am not going to go through the whole fedora-review template, as this package
uses go2rpm. 

- The specfile is sane.
- License is correct
- Builds successfully in mock
- No rpmlint errors
- %check section passes
- The latest version is packaged
- The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- Add package to release-monitoring.org
- Add package to Koschei.
- Give go-sig privileges on package
- Close the review bug by referencing it in the rpm changelog and/or the Bodhi
ticket.

Thanks!

Comment 6 Maxwell G 2022-06-25 02:43:40 UTC

@bperkins, is there a reason that you haven't imported this package?

Comment 7 Mark E. Fuller 2022-07-15 07:27:31 UTC

Stalled package under re-review

*** This bug has been marked as a duplicate of bug 2107472 ***

Comment 8 Red Hat Bugzilla 2023-09-15 01:50:33 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 365 days