Bug 2032563

Summary: Review Request: rust-der_derive - Custom derives for Choice and Message traits from the der crate
Product: [Fedora] Fedora Reporter: Fabio Valentini <decathorpe>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-01-11 18:16:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2034212    

Description Fabio Valentini 2021-12-14 17:50:19 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-der_derive.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-der_derive-0.4.1-1.fc35.src.rpm

Description:
Custom derive support for the `der` crate's `Choice` and `Message` traits.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2021-12-14 17:50:21 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=79984460

Comment 2 Fabio Valentini 2021-12-14 17:58:45 UTC
Note: Not packaging the latest version is intentional.
The reason I am packaging this crate is that version 0.4.x of this crate appears in the dependency tree of rust-rsa 0.5.0, which I am working on updating.
I will update the crate once that is possible.

Comment 3 Michel Lind 2022-01-11 00:50:38 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- X latest version of the crate is packaged => explanation given
- license matches upstream specification (MIT or ASL 2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 5 Gwyn Ciesla 2022-01-11 15:07:27 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-der_derive