Bug 2032845

Summary: SSP CR | reason field's value in SSP CR status.conditions is not CamelCased
Product: Container Native Virtualization (CNV) Reporter: ibesso <ibesso>
Component: SSPAssignee: Felix Matouschek <fmatouschek>
Status: CLOSED ERRATA QA Contact: Roni Kishner <rkishner>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 4.10.0CC: akrejcir, cnv-qe-bugs, dholler, ksimon, rnetser
Target Milestone: ---   
Target Release: 4.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: kubevirt-ssp-operator-container-v4.10.0-39 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-03-16 15:59:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description ibesso 2021-12-15 11:00:54 UTC
Description of problem:
----------------------
In SSP CR, the reason field's value is in lowercase, whereas other fields are not, also comparing to all other status.conditions fields in other CRs (HCO CR, CDI CR).



Version-Release number of selected component (if applicable):
------------------------------------------------------------
4.10.0-477



How reproducible:
----------------
100%



Steps to Reproduce:
------------------
oc get -A ssp -oyaml



Actual results:
--------------
$ oc get ssp -n openshift-cnv ssp-kubevirt-hyperconverged -ojson |jq '.status.conditions'
[
  {
    "lastHeartbeatTime": "2021-12-14T14:30:07Z",
    "lastTransitionTime": "2021-12-14T14:30:07Z",
    "message": "All SSP resources are available",
    "reason": "available",
    "status": "True",
    "type": "Available"
  },
  {
    "lastHeartbeatTime": "2021-12-14T14:30:07Z",
    "lastTransitionTime": "2021-12-14T14:30:07Z",
    "message": "No SSP resources are progressing",
    "reason": "progressing",
    "status": "False",
    "type": "Progressing"
  },
  {
    "lastHeartbeatTime": "2021-12-14T14:30:07Z",
    "lastTransitionTime": "2021-12-14T14:30:07Z",
    "message": "No SSP resources are degraded",
    "reason": "degraded",
    "status": "False",
    "type": "Degraded"
  }
]

Expected results:
----------------
Should be Camelcase, as follows:
[
  {
    "lastHeartbeatTime": "2021-12-14T14:30:07Z",
    "lastTransitionTime": "2021-12-14T14:30:07Z",
    "message": "All SSP resources are available",
    "reason": "Available",
    "status": "True",
    "type": "Available"
  },
  {
    "lastHeartbeatTime": "2021-12-14T14:30:07Z",
    "lastTransitionTime": "2021-12-14T14:30:07Z",
    "message": "No SSP resources are progressing",
    "reason": "Progressing",
    "status": "False",
    "type": "Progressing"
  },
  {
    "lastHeartbeatTime": "2021-12-14T14:30:07Z",
    "lastTransitionTime": "2021-12-14T14:30:07Z",
    "message": "No SSP resources are degraded",
    "reason": "Degraded",
    "status": "False",
    "type": "Degraded"
  }
]



Additional info:
---------------
According to https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties

 // +optional
  Reason             *string            `json:"reason,omitempty" description:"one-word CamelCase reason for the condition's last transition"`

Comment 1 Roni Kishner 2022-01-20 09:13:32 UTC
Verified on ssp-operator-container-v4.10.0-39

Comment 6 errata-xmlrpc 2022-03-16 15:59:44 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 4.10.0 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0947