Bug 2033391

Summary:	csi-driver-shared-resource-operator sets unused CVO-manifest annotations
Product:	OpenShift Container Platform	Reporter:	W. Trevor King <wking>
Component:	Storage	Assignee:	Gabe Montero <gmontero>
Storage sub component:	Shared Resource CSI Driver	QA Contact:	Priti Kumar <prikumar>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	low
Priority:	low	CC:	aos-bugs, gmontero, pkumari
Version:	4.10
Target Milestone:	---
Target Release:	4.10.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-03-10 16:34:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description W. Trevor King 2021-12-16 16:32:21 UTC

$ git --no-pager grep include.release.openshift.io assets
assets/servicemonitor.yaml:    include.release.openshift.io/ibm-cloud-managed: "true"
assets/servicemonitor.yaml:    include.release.openshift.io/self-managed-high-availability: "true"
assets/servicemonitor.yaml:    include.release.openshift.io/single-node-developer: "true"
$ git blame assets/servicemonitor.yaml | grep -4 include.release.openshift.io
49954514 (gabemontero 2021-10-28 17:20:21 -0400  4) metadata:
5d3ff090 (Corey Daley 2021-11-18 12:14:03 -0500  5)   name: shared-resource-csi-driver-node-monitor
49954514 (gabemontero 2021-10-28 17:20:21 -0400  6)   namespace: openshift-cluster-csi-drivers
49954514 (gabemontero 2021-10-28 17:20:21 -0400  7)   annotations:
49954514 (gabemontero 2021-10-28 17:20:21 -0400  8)     include.release.openshift.io/ibm-cloud-managed: "true"
49954514 (gabemontero 2021-10-28 17:20:21 -0400  9)     include.release.openshift.io/self-managed-high-availability: "true"
49954514 (gabemontero 2021-10-28 17:20:21 -0400 10)     include.release.openshift.io/single-node-developer: "true"
49954514 (gabemontero 2021-10-28 17:20:21 -0400 11) spec:
49954514 (gabemontero 2021-10-28 17:20:21 -0400 12)   endpoints:
5d3ff090 (Corey Daley 2021-11-18 12:14:03 -0500 13)   - bearerTokenFile: /var/run/secrets/kubernetes.io/serviceaccount/token
5d3ff090 (Corey Daley 2021-11-18 12:14:03 -0500 14)     interval: 30s

But those include.release.openshift.io/* cluster-profile annotations only matter if the manifest is being reconciled by the CVO, and this one is not:

$ oc adm release extract --to manifests registry.ci.openshift.org/ocp/release:4.10.0-0.ci-2021-12-16-075804
$ grep -r csi-driver manifests | grep -v 'image-references:\|cluster-storage-operator_03_credentials_request'
manifests/0000_50_cluster-storage-operator_02_csi_driver_operators_namespace.yaml:  name: openshift-cluster-csi-drivers

We should drop the annotations from that manifest.

Comment 5 Priti Kumari 2022-01-05 06:26:28 UTC

Verified with 4.10.0-0.nightly-2021-12-23-153012

Comment 8 errata-xmlrpc 2022-03-10 16:34:29 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056