Bug 2033482

Summary:	[vsphere] two variables in tf are undeclared and get warning message during installation
Product:	OpenShift Container Platform	Reporter:	jima
Component:	Installer	Assignee:	Jeremiah Stuever <jstuever>
Installer sub component:	openshift-installer	QA Contact:	jima
Status:	CLOSED ERRATA	Docs Contact:
Severity:	low
Priority:	low	CC:	jstuever
Version:	4.10
Target Milestone:	---
Target Release:	4.11.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-08-10 10:40:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description jima 2021-12-17 01:20:44 UTC

Version:
4.10

Platform: vsphere IPI

What happened?
After separating tf files into smaller configurations on vsphere platform, there are some warning messages in the installer log, and show that two variables bootstrap_moid and control_plane_moids are undeclared, but used.

12-15 12:03:07.866  level=debug msg=Warning: Value for undeclared variable
12-15 12:03:07.866  level=debug
12-15 12:03:07.866  level=debug msg=The root module does not declare a variable named "bootstrap_moid" but a value
12-15 12:03:07.866  level=debug msg=was found in file
12-15 12:03:07.866  level=debug msg="/tmp/openshift-install-master-3037452068/bootstrap.tfvars.json". To use this
12-15 12:03:07.866  level=debug msg=value, add a "variable" block to the configuration.
12-15 12:03:07.866  level=debug
12-15 12:03:07.866  level=debug msg=Using a variables file to set an undeclared variable is deprecated and will
12-15 12:03:07.866  level=debug msg=become an error in a future release. If you wish to provide certain "global"
12-15 12:03:07.866  level=debug msg=settings to all configurations in your organization, use TF_VAR_...
12-15 12:03:07.866  level=debug msg=environment variables to set these instead.

.....

12-15 12:14:00.782  level=debug msg=Warning: Value for undeclared variable
12-15 12:14:00.782  level=debug
12-15 12:14:00.782  level=debug msg=The root module does not declare a variable named "control_plane_ips" but a
12-15 12:14:00.782  level=debug msg=value was found in file
12-15 12:14:00.782  level=debug msg="/tmp/openshift-install-bootstrap-1695574444/master.tfvars.json". To use this
12-15 12:14:00.782  level=debug msg=value, add a "variable" block to the configuration.
12-15 12:14:00.782  level=debug
12-15 12:14:00.782  level=debug msg=Using a variables file to set an undeclared variable is deprecated and will
12-15 12:14:00.782  level=debug msg=become an error in a future release. If you wish to provide certain "global"
12-15 12:14:00.782  level=debug msg=settings to all configurations in your organization, use TF_VAR_...
12-15 12:14:00.782  level=debug msg=environment variables to set these instead.

there is no function impact, installation is successful, but it's better to fix it.

What did you expect to happen?
Two variables should be declared.

How to reproduce it (as minimally and precisely as possible)?
always on 4.10 when installing ipi cluster on vsphere.

Anything else we need to know?

Comment 1 Matthew Staebler 2021-12-17 01:39:01 UTC

Oops. I did not mean to close this.

Comment 4 jima 2022-04-12 06:16:55 UTC

Built image from cluster-bot which include installer PR#5778, and verified this bz. 
registry.build01.ci.openshift.org/ci-ln-36jj9xb/release:latest.

Warning message about undeclared variable are not present any more in output after creating control plane vms and destroying bootstrap vm.
$ ./openshift-install create cluster --dir ipi --log-level debug
DEBUG OpenShift Installer 4.11.0-0.ci.test-2022-04-12-042211-ci-ln-36jj9xb-latest 
...
DEBUG vsphere_virtual_machine.vm_master[1]: Creating... 
DEBUG vsphere_virtual_machine.vm_master[2]: Creating... 
DEBUG vsphere_virtual_machine.vm_master[0]: Creating... 
DEBUG vsphere_virtual_machine.vm_master[1]: Still creating... [10s elapsed] 
DEBUG vsphere_virtual_machine.vm_master[2]: Still creating... [10s elapsed] 
DEBUG vsphere_virtual_machine.vm_master[0]: Still creating... [10s elapsed] 
DEBUG vsphere_virtual_machine.vm_master[1]: Still creating... [20s elapsed] 
DEBUG vsphere_virtual_machine.vm_master[2]: Still creating... [20s elapsed] 
DEBUG vsphere_virtual_machine.vm_master[0]: Still creating... [20s elapsed] 
DEBUG vsphere_virtual_machine.vm_master[0]: Creation complete after 22s [id=422c9ffd-5cd2-6d58-185a-2e0f83d88771] 
DEBUG vsphere_virtual_machine.vm_master[1]: Creation complete after 22s [id=422ce754-5691-1675-ea2e-590d754a1987] 
DEBUG vsphere_virtual_machine.vm_master[2]: Creation complete after 22s [id=422c7676-ba47-eb31-6c78-b63f107e7f3f] 
DEBUG                                              
DEBUG Apply complete! Resources: 3 added, 0 changed, 0 destroyed. 
DEBUG                                              
DEBUG Outputs:                                     
DEBUG                                              
DEBUG control_plane_ips = [                        
DEBUG   tostring(null),                            
DEBUG   tostring(null),                            
DEBUG   tostring(null),                            
DEBUG ]                                            
DEBUG control_plane_moids = [                      
DEBUG   "vm-792476",                               
DEBUG   "vm-792474",                               
DEBUG   "vm-792475",                               
DEBUG ]                                                                    
......
DEBUG vsphere_virtual_machine.vm_bootstrap: Destroying... [id=422c3f04-8ee2-34c5-f1c3-6a6c2dfbba23] 
DEBUG vsphere_virtual_machine.vm_bootstrap: Still destroying... [id=422c3f04-8ee2-34c5-f1c3-6a6c2dfbba23, 10s elapsed] 
DEBUG vsphere_virtual_machine.vm_bootstrap: Still destroying... [id=422c3f04-8ee2-34c5-f1c3-6a6c2dfbba23, 20s elapsed] 
DEBUG vsphere_virtual_machine.vm_bootstrap: Still destroying... [id=422c3f04-8ee2-34c5-f1c3-6a6c2dfbba23, 30s elapsed] 
DEBUG vsphere_virtual_machine.vm_bootstrap: Destruction complete after 38s 
DEBUG                                              
DEBUG Destroy complete! Resources: 1 destroyed.    
......

Comment 11 errata-xmlrpc 2022-08-10 10:40:43 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069