Bug 2034211

Summary: Review Request: rust-const-oid - Const-friendly implementation of the ISO/IEC Object Identifier (OID) standard
Product: [Fedora] Fedora Reporter: Fabio Valentini <decathorpe>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: eclipseo, michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-01-11 18:17:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2034212    

Description Fabio Valentini 2021-12-20 12:09:32 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-const-oid.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-const-oid-0.6.2-1.fc35.src.rpm

Description:
Const-friendly implementation of the ISO/IEC Object Identifier (OID) standard
as defined in ITU X.660, with support for BER/DER encoding/decoding as well as
heapless no_std (i.e. embedded) support.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2021-12-20 12:09:34 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=80227293

Comment 2 Fabio Valentini 2021-12-20 12:10:39 UTC
*** Bug 1981120 has been marked as a duplicate of this bug. ***

Comment 3 Michel Lind 2022-01-11 01:34:32 UTC
Consider packaging 0.7.1, but if you need an older version specifically, that's fine too.

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- X latest version of the crate is packaged
- license matches upstream specification (MIT or ASL 2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 4 Fabio Valentini 2022-01-11 10:46:53 UTC
Ah, yes, I forgot to add for this package too:
I need version 0.6.x for now, and will update to the latest version once that is possible.

Anyway, thanks for the review!

https://pagure.io/releng/fedora-scm-requests/issue/40751
https://pagure.io/releng/fedora-scm-requests/issue/40752
https://pagure.io/releng/fedora-scm-requests/issue/40753

Comment 5 Gwyn Ciesla 2022-01-11 15:08:19 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-const-oid