Bug 2034212

Summary: Review Request: rust-der - Pure Rust embedded-friendly implementation of DER for ASN.1
Product: [Fedora] Fedora Reporter: Fabio Valentini <decathorpe>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: eclipseo, michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-01-11 18:17:49 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2032563, 2034211    
Bug Blocks: 2034213, 2034226, 2034228, 2034230    

Description Fabio Valentini 2021-12-20 12:13:54 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-der.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-der-0.4.5-1.fc35.src.rpm

Description:
Pure Rust embedded-friendly implementation of the Distinguished Encoding Rules
(DER) for Abstract Syntax Notation One (ASN.1) as described in ITU X.690 with
full support for heapless no_std targets.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2021-12-20 12:13:57 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=80227319

Comment 2 Fabio Valentini 2021-12-20 12:15:45 UTC
*** Bug 1981121 has been marked as a duplicate of this bug. ***

Comment 3 Fabio Valentini 2021-12-20 12:17:05 UTC
Note: Not packaging the latest version is intentional.

The reason I am packaging this crate is that version 0.4.x of this crate appears in the dependency tree of rust-rsa 0.5.0, which I am working on updating.
I will update the crate once that is possible.

Comment 4 Michel Lind 2022-01-11 01:44:06 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- X latest version of the crate is packaged => explanation given
- license matches upstream specification (MIT or ASL 2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 6 Gwyn Ciesla 2022-01-11 15:09:13 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-der