Bug 2034364

Summary:	MCO uses out of date fork of library-go, causing various buggy object syncs
Product:	OpenShift Container Platform	Reporter:	mkenigsb
Component:	Machine Config Operator	Assignee:	mkenigsb
Machine Config Operator sub component:	Machine Config Operator	QA Contact:	Rio Liu <rioliu>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	low
Priority:	low	CC:	aos-bugs, jerzhang, kgarriso, mkrejci, wking
Version:	4.10
Target Milestone:	---
Target Release:	4.10.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-03-16 11:12:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description mkenigsb 2021-12-20 18:58:53 UTC

In the MCO project today, code under ./lib is basically a fork of an old project that now fully lives in openshift/library-go. The old MCO fork has caused us various issues in the past, for example:

1. https://bugzilla.redhat.com/show_bug.cgi?id=1959258
2. https://bugzilla.redhat.com/show_bug.cgi?id=1981549

Specifically for 2, we opted to just fix the proxy case (environment variables) for now. The bug still applies to other variables not being synced correctly, such as ports or volumnmounts, which we opted to skip as part of that BZ.

This BZ will thus track our effort to eliminate other buggy behaviour in the old MCO fork, by moving to the updated library-go functionality. This is not a rework, but rather an update of an old code to eliminate bugs.

Comment 7 W. Trevor King 2022-03-11 18:49:17 UTC

This bug was pointed at 4.10 release targets after the 4.10.3 errata were mostly wrapped up, so even though the code shipped with 4.10.3:

$ oc adm release info --commits quay.io/openshift-release-dev/ocp-release:4.10.3-x86_64 | grep machine-config-operator
  machine-config-operator                        https://github.com/openshift/machine-config-operator                        14a1ca2cb91ff7e0faf9146b21ba12cd6c652d22
$ git log --oneline 14a1ca2cb91ff7e0faf9146b21ba12cd6c652d22 | grep '#2833\|#2893'
3e9f2ca5 Merge pull request #2893 from mkenigs/set_owner
62fb49f2 Merge pull request #2833 from mkenigs/use-library-go

I'm going to move the target to 4.10.z because it will be attached to a later errata.

Comment 9 errata-xmlrpc 2022-03-16 11:12:07 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.10.4 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:0811