Bug 2034385

Summary:	Spyder 5 code style and docstring underlining style warnings broken.
Product:	[Fedora] Fedora	Reporter:	Golanv <mullein>
Component:	spyder	Assignee:	Mukundan Ragavan <nonamedotc>
Status:	CLOSED EOL	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	35	CC:	nonamedotc
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-12-13 16:08:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Golanv 2021-12-20 19:22:35 UTC

Description of problem:

Code underlining for docstring and code style warnings do not work.

Version-Release number of selected component (if applicable):

Spyder 5.1.5


How reproducible:

Always


Steps to Reproduce:
1.  From Preferences > Completions and linting > enable code style linting (Code style and formatting tab) and enable docstring style linting (Docstring style tab).

2.  Make sure code style, docstring, and errors and warnings underlining is selected from the Source menu

Actual results:

No errors are underlined.


Expected results:

Code style and docstring errors should be underlined.


Additional info:

This is just a lack of appropriate python dependencies.  I think the needed packages are:

python3-pydocstyle
python3-autopep8
python3-pycodestyle

Comment 1 Golanv 2021-12-21 18:17:18 UTC

I noticed that these dependencies are not listed in the spyder setup.py on Github, which the Fedora package apparently pulls from (openSUSE manually includes these dependencies in their spec file).  Is this something that should be resolved upstream?

Comment 2 Mukundan Ragavan 2022-01-03 14:37:50 UTC

preferably upstream. would you willing to ask upstream and post a link here?

it is also possible that spyder expects one of it's other deps to pull these.

Comment 3 Golanv 2022-01-11 16:05:52 UTC

Sure.  This is done:

https://github.com/spyder-ide/spyder/issues/17174

Comment 4 Golanv 2022-01-12 14:54:42 UTC

So, the bug was immediately closed as the python-lsp-server package should take care of the needed dependencies.  The Fedora spec file for python3-lsp-server does show the "all" extra requirement for %pyproject_buildrequires, but does not seem to otherwise pull those dependencies when installing the package.  Perhaps this is a bug with the python3-lsp-server package in Fedora?

Comment 5 Mukundan Ragavan 2022-01-12 15:33:05 UTC

Thanks for filing this upstream and yeah, I noticed. 

I maintain lsp-server as well anyway. I will look. If nothing works, I will just explicitly list in the spec file.

Comment 6 Mukundan Ragavan 2022-01-16 15:47:54 UTC

Okay, I fixed this in rawhide for python-lsp-server.

https://koji.fedoraproject.org/koji/rpminfo?rpmID=28836126

I will update spyder to 5.2.1 shortly.

Since these are major version updates, I will only update on rawhide.

Comment 7 Mukundan Ragavan 2022-01-16 16:51:20 UTC

This should now be fixed in rawhide. Will you be able to test it?

Comment 8 Golanv 2022-01-18 19:37:06 UTC

Do you think python3-pydocstyle should be added as a python-lsp-server dependency as well?  Spyder can check for docstrings as well, but python3-docstyle is needed.  Otherwise, I can confirm the python3-autopep8 and python3-pycodestyle are pulled in with python-lsp-server (and python3-spyder) as expected!

Comment 9 Mukundan Ragavan 2022-01-18 21:34:41 UTC

Oops. I missed the docstyle.

Should be fixed now - https://koji.fedoraproject.org/koji/buildinfo?buildID=1879260

If this works, we can close this bug report.

Comment 10 Golanv 2022-01-21 23:11:09 UTC

Yep, I can confirm that this is working in Rawhide.  Thanks!  Please close.

Comment 11 Ben Cotton 2022-11-29 17:31:20 UTC

This message is a reminder that Fedora Linux 35 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 35 on 2022-12-13.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '35'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 35 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 12 Ben Cotton 2022-12-13 16:08:47 UTC

Fedora Linux 35 entered end-of-life (EOL) status on 2022-12-13.

Fedora Linux 35 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of Fedora Linux
please feel free to reopen this bug against that version. Note that the version
field may be hidden. Click the "Show advanced fields" button if you do not see
the version field.

If you are unable to reopen this bug, please file a new report against an
active release.

Thank you for reporting this bug and we are sorry it could not be fixed.