Bug 2034985

Summary:	Avoid hardcoded URLs to cloud images and container disks
Product:	OpenShift Container Platform	Reporter:	Dominik Holler <dholler>
Component:	Console Kubevirt Plugin	Assignee:	Aviv Turgeman <aturgema>
Status:	CLOSED DEFERRED	QA Contact:	Guohua Ouyang <gouyang>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.10	CC:	aos-bugs, aturgema, tnisan, yzamir
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-04-05 06:55:15 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2031857
Bug Blocks:

Description Dominik Holler 2021-12-22 16:34:32 UTC

Description of problem:
Currently, the example URLs of cloud images and container disks are hard coded in UI code. It would be better if these URLs would be extracted from the templates.

Version-Release number of selected component (if applicable):
4.10



Steps to Reproduce:
1. Install updated common-templates which support a new fedora version

Actual results:
Old URL of example container disk and cloud image will be shown in UI.

Expected results:
New URL of example container disk and cloud image will be shown in UI.

Additional info:

Comment 1 Aviv Turgeman 2022-01-03 11:24:07 UTC

Hi Dominik

If you help me clarify something that would be very helpful
Is the URL you are referring to is this [1]? if so, I could only see a URL for fedora,
Is a similar URL will enter into all template descriptions or this is relevant for fedora only?

[1] https://github.com/kubevirt/common-templates/blob/master/templates/fedora.tpl.yaml#L11

Comment 2 Dominik Holler 2022-01-03 11:35:55 UTC

(In reply to aviv turgeman from comment #1)
> Hi Dominik
> 
> If you help me clarify something that would be very helpful
> Is the URL you are referring to is this [1]? if so, I could only see a URL
> for fedora,
> Is a similar URL will enter into all template descriptions or this is
> relevant for fedora only?
> 
> [1]
> https://github.com/kubevirt/common-templates/blob/master/templates/fedora.
> tpl.yaml#L11

Hi Aviv,
no, the idea is to have a machine-readable solution, e.g.
during generating the templates, a new annotation could be introduced which holds the URLs to the cloud images and container disks.
If libosinfo does not provide the URLs, they have to be hard coded.

Comment 3 Tal Nisan 2022-01-04 12:32:06 UTC

Removing target milestone as this bug depends on bug 2031857 which will be fixed in 4.11

Comment 4 Yaacov Zamir 2022-04-05 06:54:38 UTC

closing will be tracked via JIRA https://issues.redhat.com/browse/CNV-15583