Bug 2035409

Summary: OLM E2E test depends on operator package that's no longer published
Product: OpenShift Container Platform Reporter: Nick Hale <nhale>
Component: Management ConsoleAssignee: Harish Govindarajulu <hgovinda>
Status: CLOSED ERRATA QA Contact: Siva Reddy <schituku>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 4.10CC: aos-bugs, dtaylor, jhadvig, nmukherj, spadgett, yapei
Target Milestone: ---   
Target Release: 4.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-03-12 04:40:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2034409    

Description Nick Hale 2021-12-24 00:03:24 UTC
Description of problem:

A console e2e test depends on an operator package that isn't published to the default 4.10 redhat-operators catalog, causing it to fail in PRs attempting to bump the catalog image from 4.9 to 4.10; in-turn, blocking the release.

Thoughts:

Ideally, these tests shouldn't depend on specific optional content shipped in OpenShift catalogs. However, if we find ourselves short on time, we could be unblocked by depending on a different operator; one that's available in the 4.10 catalog. Alternatively, we could override or disable the test in the short-term, although that will leave us (OLM) open to regressing.

See also:

Hardcoded dependency: https://github.com/openshift/console/blob/f240986d7751abcf3292ed6522b3b78c5c87a5c5/frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/create-namespace.spec.ts#L26

PR blocked by `e2e-aws-console` (prow job that runs the console test for operator-marketplace): https://github.com/operator-framework/operator-marketplace/pull/456#issuecomment-1000565909

Example of a failed test: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/operator-framework_operator-marketplace/456/pull-ci-operator-framework-operator-marketplace-master-e2e-aws-console-olm/1467862771302404096

4.10 catalog: registry.redhat.io/redhat/redhat-operator-index:v4.10 
4.9 catalog: registry.redhat.io/redhat/redhat-operator-index:v4.9

Comment 1 Jakub Hadvig 2022-01-03 10:25:23 UTC
Weird that 'Advanced Cluster Management for Kubernetes' with the data-test 'advanced-cluster-management-redhat-operators-openshift-marketplace' attribute isn't published to the default 4.10 redhat-operators catalog.
@David please check https://github.com/operator-framework/operator-marketplace/pull/456#issuecomment-1003996499

Comment 2 David Taylor 2022-01-03 14:31:16 UTC
Reassigning to Dev Console as I am not familiar with this OLM test & operator usage.

Comment 3 Nick Hale 2022-01-03 15:55:53 UTC
> Weird that 'Advanced Cluster Management for Kubernetes' with the data-test 'advanced-cluster-management-redhat-operators-openshift-marketplace' attribute isn't published to the default 4.10 redhat-operators catalog.

@jhadvig, there's no guarantee that the operator will be present in the catalog shipped with 4.11, or 4.12, or any future minor release of OpenShift. This is because we've switched the publishing strategy from publishing a single catalog to all minor releases to publishing a unique catalog for each minor release.

I've also responded with a suggestion about how we could drop the marketplace dependency in short order: https://github.com/operator-framework/operator-marketplace/pull/456#issuecomment-1004180277

> Reassigning to Dev Console as I am not familiar with this OLM test & operator usage.

@jhadvig @dtaylor isn't the component under test here part of the admin console? has that changed? If not, I don't think this bug should be listed under the dev console.

Comment 4 Jakub Hadvig 2022-01-03 16:51:05 UTC
No this should stay under Management Console component.
Assigning to Harish since he was working on this piece.

Comment 8 Siva Reddy 2022-01-09 23:53:17 UTC
Cluster Version:
4.10.0-0.nightly-2022-01-07-181043

Verified that the catalog source is now changed to the operator that is available.

Comment 11 errata-xmlrpc 2022-03-12 04:40:05 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056