Bug 2035548
| Summary: | Review Request: rust-deser-hjson - Hjson deserializer for Serde | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-10-26 03:08:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2035568 | ||
|
Description
Davide Cavalca
2021-12-24 15:43:55 UTC
Taking on this review. === Are you sure you need glassbench for this package? It seems to be a benchmark-only dependency. And since we neither build nor run benchmarks in Fedora RPM builds, you should be able to drop the glassbench dev-dependency from Cargo.toml entirely. You're right, it doesn't seem to be needed for this to build and the tests to pass. Spec URL: https://dcavalca.fedorapeople.org/review/rust-deser-hjson/rust-deser-hjson.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-deser-hjson/rust-deser-hjson-1.0.2-1.fc37.src.rpm Changelog: - re-run rust2rpm - drop benchmark-only dependency Ooops, I'm sorry for the long delay here. This review seems to have slipped through multiple cracks ... === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches === Please regenerate the packaging with rust2rpm v22 before importing it into dist-git. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-deser-hjson FEDORA-2022-e268aea46b has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-e268aea46b FEDORA-2022-e268aea46b has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-118e693b09 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-118e693b09 FEDORA-2022-118e693b09 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-118e693b09 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-118e693b09 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-118e693b09 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. |