Bug 2035591

Summary:	Specfile uses /sbin/busybox instead of %{_sbindir}/busybox
Product:	[Fedora] Fedora	Reporter:	Maxwell G <maxwell>
Component:	busybox	Assignee:	Tom "spot" Callaway <spotrh>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	admiller, dvlasenk, spotrh
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-12-29 17:25:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Maxwell G 2021-12-25 03:16:15 UTC

Is there a reason this specfile goes against the packaging guidelines and doesn't use the proper macros? I was going to submit a PR to fix the issue, but I figured I'd check first to make sure there isn't some legacy reason that this specfile doesn't use the macros.

Comment 1 Tom "spot" Callaway 2021-12-29 17:25:52 UTC

It is a rather old spec file (the first revision was created in 2001). In the long long ago, there was a difference between /sbin and /usr/sbin. Since %{_sbindir} is /usr/sbin, it was hardcoded in the spec file like that, because you wanted busybox bits available even when /usr was not mounted (yet). Obviously, this is no longer the case (/sbin is now a link to /usr/sbin), so I've gone ahead and fixed the macros in the 1.35.0 build in rawhide.