Bug 203572
| Summary: | On the config file details page, the binary toggle link gives 404 | ||
|---|---|---|---|
| Product: | [Retired] Red Hat Network | Reporter: | Ken Ganong <kganong> |
| Component: | RHN/Web Site | Assignee: | Grant Gainey <ggainey> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | wes hayutin <whayutin> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rhn420 | CC: | duffy, rhn-bugs |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rhn500h | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-03-13 02:51:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 192224 | ||
|
Description
Ken Ganong
2006-08-22 14:57:06 UTC
The real issue here is that the binary/text toggle needs to be just one more piece of "additional details" when we create a new revision of a config-file. I'm proposing that we add a binary/text radiogroup in the additional-details section of the file-details page. Comments from Ken or Mo? If it is a radio-group, when do you submit your changes? What happens if the user changes this to binary and types into the file contents. Remove the link, make the text/binary just one more property of the form - the change is submitted along with everything else. One has to create a new revision for this change (just as with any other change), so this just becomes one more attribute to set on the new revision. It's no different than changing the delimiters or the mode or the user/group info. Can I vote for both? The text link is kind of a 'something is wrong. if you want to fix it, click here nice and easy' But I see the need for a property too, so a group in the additional file details labeled: "File type:" and I would make it a dropdown that says either 'Binary File' or 'Text File'. (The rationale for a dropdown over a radio select is that it's dual-purpose right? Displays the current status of the file and allows you to change it. It's easier to tell at a glance what the current state is if thats the only one visible (the other state hidden behind the drop down).) The only problem I have with with keeping the link, is that the link would need
to do two things - change the property, and then submit the form (so we don't
lose all the rest of the user's data). I have a problem with separating out
this one property for special behavior. "If you don't like these macro
delimiters, click here to change them" "If you don't like this file-permission
setting, click here to change it" - you're already "here", this is where you
change these things. I'd much prefer commentary ("If this should be a binary
file, change it in the dropdown above") instead of special-casing the form-submit.
RE dropdown - sounds good to me!
Comments?
Sounds good. Let's change the commentary to: "If this should be a binary file, you can change it using the 'File type' drop-down in the 'Additional File Details' section above." :) Moving bugs to ON_DEV Moving my bugs to ON_QA Passing on my config management bugs to ggainey This looks good Closed in the rhn500h Release. |