Bug 2036018
| Summary: | ROOK_CSI_* overrides missing from the CSV in 4.10 | ||
|---|---|---|---|
| Product: | [Red Hat Storage] Red Hat OpenShift Data Foundation | Reporter: | Aditi <adukle> |
| Component: | ocs-operator | Assignee: | Jose A. Rivera <jarrpa> |
| Status: | CLOSED ERRATA | QA Contact: | Jilju Joy <jijoy> |
| Severity: | urgent | Docs Contact: | |
| Priority: | urgent | ||
| Version: | 4.10 | CC: | amuller, anpicker, aos-bugs, branto, dahorak, ebenahar, erooth, juzhao, madam, muagarwa, ocs-bugs, odf-bz-bot, rperiyas, shan, sostapov, srai, uchapaga |
| Target Milestone: | --- | Keywords: | Regression |
| Target Release: | ODF 4.10.0 | ||
| Hardware: | All | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | ocs-registry:4.10.0-70 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-04-13 18:50:46 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Aditi
2021-12-29 10:20:28 UTC
I took a look here and this is actually an issue with the ocs-operator repo that no longer generates the ROOK_CSI_* overrides in the CSV for some reason so we are using upstream images (which are built for amd64 only) in our downstream builds. Just to reiterate -- this is not just cephcsi image missing the override, there is no override for any of the sidecar images in the ocs-operator-bundle CSV in ODF 4.10. Retargetting. Looking at the git log, this has been the case at least since 4.10.0-32 which we built on December 7th. The build 4.10.0-29 still had the ROOK_CSI_* overrides in the CSV so I suspect the regression to occur somewhere around that time. The commit-wise this is: 2667179611d88ec00bf136b74a9f424e9d76be1d -- working bf0946e7b4d47b799d209c491f0fcfbd71a4295c -- broken I can only see one commit in that range and it does not seem to be related to the CSV generation. I suspect this started occurring because of changes in rook around that time. The changes in this https://github.com/red-hat-storage/ocs-operator/commit/bf0946e7b4d47b799d209c491f0fcfbd71a4295c were required in SCC in Openshift. I don't idea about CSV generation but I don't think it should impact CSV. @branto We probably stopped adding env vars like "ROOK_CSI_SNAPSHOTTER_IMAGE" etc while generating CSV. I tried generating CSV with master and release-4.9 branches and it's working fine for me. Can you check if something changed with downstream script? Testing the latest rook image, it looks like the issue is due to change of CSV name in Rook. Which is causing environment variable injection to fail. It's a quick fix. Providing devel_ack+ . I have fixed the issue in Rook and resynced 4.10 with latest rook v1.8 here https://github.com/red-hat-storage/rook/pull/325 yesterday. *** Bug 2037718 has been marked as a duplicate of this bug. *** I am able to deploy ODF 4.10(4.10.0-73) now. Thanks Thanks Aditi for confirming. Verified that downstream csi builds are present. Verified in version: ODF 4.10.0-79 OCP 4.10.0-0.nightly-2022-01-10-144202 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: Red Hat OpenShift Data Foundation 4.10.0 enhancement, security & bug fix update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2022:1372 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: Red Hat OpenShift Data Foundation 4.10.0 enhancement, security & bug fix update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2022:1372 |