Bug 2036633

pcs-0.10.12 adds support for OCF 1.1 resource agents. In order to be able to distinguish OCF 1.0 and OCF 1.1 agents and process them correctly, pcs validates agents' metadata against OCF schema. This prevents pcs from crashing due to accessing missing parts of metadata which are mandatory by the standard yet missing in the actual agent not complying to the standard.

The drbd agent specifies <content type="numeric"/> for parameter 'wfc_timeout'. This is not in compliance with OCF 1.0 standard and therefore pcs is right to produce an error. However, this violation is insignificant to pcs, therefore I'm going to relax the validation to make pcs compatible with the existing drbd agent.

Upstream patch:
https://github.com/ClusterLabs/pcs/commit/f34db4f12e100b177e8b56206325e3ae1c28b455


For tests, see comment 0.

Thanks a lot!

Do you any idea on when a new package version of pcs including this fix will be available?

Best regards,
Marco

(In reply to Marco Fortina from comment #5)
> Do you any idea on when a new package version of pcs including this fix will be available?


Probably in a few weeks. In the meantime, you can either downgrade to pcs-0.10.11, or use --force, or modify ocf-1.0.rng file in your pcs installation, or fix the drbd agent.

DevTestResults:

[root@r8-node-01 pcs]# rpm -q pcs
pcs-0.10.12-3.el8.x86_64

[root@r8-node-01 pcs]# dnf -y install https://www.elrepo.org/elrepo-release-8.el8.elrepo.noarch.rpm
...
[root@r8-node-01 pcs]# dnf install drbd84-utils
...

[root@r8-node-01 pcs]# pcs resource create drbd ocf:linbit:drbd drbd_resource=resource0
[root@r8-node-01 pcs]# echo $?
0

[root@virt-485 ~]# dnf -y install https://www.elrepo.org/elrepo-release-8.el8.elrepo.noarch.rpm
{...}

[root@virt-485 ~]# dnf install drbd84-utils
{...}


BEFORE:
=======

[root@virt-485 ~]# rpm -q pcs
pcs-0.10.12-2.el8.x86_64

[root@virt-485 ~]# pcs resource create drbd ocf:linbit:drbd drbd_resource=resource0
Error: Agent 'ocf:linbit:drbd' is not installed or does not provide valid metadata: Element content failed to validate content, line 117, use --force to override
Error: Errors have occurred, therefore pcs is unable to continue
[root@virt-485 ~]# echo $?
1



AFTER:
======

[root@virt-485 ~]# rpm -q pcs
pcs-0.10.12-6.el8.x86_64


[root@virt-485 ~]# pcs resource create drbd ocf:linbit:drbd drbd_resource=resource0
[root@virt-485 ~]# echo $?
0

[root@virt-485 ~]# pcs resource update drbd ocf:linbit:drbd drbd_resource=resource1
[root@virt-485 ~]# echo $?
0

[root@virt-485 ~]# pcs resource config drbd
 Resource: drbd (class=ocf provider=linbit type=drbd)
  Attributes: drbd_resource=resource1
  Operations: demote interval=0s timeout=90 (drbd-demote-interval-0s)
              monitor interval=20 role=Slave timeout=20 (drbd-monitor-interval-20)
              monitor interval=10 role=Master timeout=20 (drbd-monitor-interval-10)
              notify interval=0s timeout=90 (drbd-notify-interval-0s)
              promote interval=0s timeout=90 (drbd-promote-interval-0s)
              reload interval=0s timeout=30 (drbd-reload-interval-0s)
              start interval=0s timeout=240 (drbd-start-interval-0s)
              stop interval=0s timeout=100 (drbd-stop-interval-0s)

[root@virt-485 ~]# pcs resource delete drbd
Deleting Resource - drbd
[root@virt-485 ~]# echo $?
0


Marking as VERIFIED SanityOnly for pcs-0.10.12-6.el8. Regression test suite will be run as part of bz2012128.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (pcs bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2022:1978