Bug 2036974

Summary:	[image-installer] Kickstart doesn't end with a new line
Product:	Red Hat Enterprise Linux 9	Reporter:	Jiri Kortus <jikortus>
Component:	osbuild-composer	Assignee:	Ondřej Budai <obudai>
Status:	CLOSED ERRATA	QA Contact:	Release Test Team <release-test-team-automation>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	9.0	CC:	jrusz, obudai
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	osbuild-45.el9	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-05-17 13:30:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1942219

Description Jiri Kortus 2022-01-04 14:39:49 UTC

This bug was initially created as a copy of Bug #2036971

Description of problem:
Kickstart contained within an "image-installer" ISO built by osbuild-composer doesn't end with a new line. This can be an issue when the kickstart is used as a base for extension with custom kickstart commands and the missing new line is not taken into account (as this results is an invalid kickstart).

Version-Release number of selected component (if applicable):
osbuild-composer-40-1.el9.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Install and start osbuild-composer.
2. Prepare and upload a blueprint.
3. Build an image-installer image type.
4. Mount the resulting image and inspect /osbuild.ks from the image.

Actual results:
The kickstart file (/osbuild.ks) doesn't end with a new line.

Expected results:
The kickstart file (/osbuild.ks) ends with a new line.

Comment 1 Jiri Kortus 2022-01-04 14:47:42 UTC

Upstream issue: https://github.com/osbuild/osbuild-composer/issues/2164

Comment 3 Jakub Rusz 2022-02-23 16:29:13 UTC

Checked the osbuild.ks in the resulting image with cat and newline is present:

[root@jrusz-rhel-8-testing temp]# cat -e osbuild.ks
liveimg --url file:///run/install/repo/liveimg.tar$

Tested with:
osbuild-composer-45-1.el9.x86_64
osbuild-48-1.el9.noarch

Moving to VERIFIED.

Comment 5 errata-xmlrpc 2022-05-17 13:30:01 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: osbuild-composer), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2522