Bug 2037497

Summary:	Concecutive dashes in OBC name
Product:	[Red Hat Storage] Red Hat OpenShift Data Foundation	Reporter:	Blaine Gardner <brgardne>
Component:	rook	Assignee:	Blaine Gardner <brgardne>
Status:	CLOSED ERRATA	QA Contact:	Mugdha Soni <musoni>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	4.7	CC:	dzaken, etamir, madam, mmuench, muagarwa, musoni, nbecker, nberry, ocs-bugs, odf-bz-bot, rcyriac, swilson
Target Milestone:	---
Target Release:	ODF 4.10.0
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	4.10.0-113	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:	2030839	Environment:
Last Closed:	2022-04-13 18:51:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2030839
Bug Blocks:

Comment 2 Blaine Gardner 2022-01-05 18:28:48 UTC

Thanks Danny Zaken for mentioning this issue to me. It also appears in Rook.

Danny has an upstream fix here in lib-bucket-provisioner: https://github.com/kube-object-storage/lib-bucket-provisioner/pull/220

Once the above fix is merged, Rook must update to the latest lib-bucket-provisioner library code to take the fix.

Comment 3 Blaine Gardner 2022-01-05 19:45:03 UTC

Danny's lib-bucket-provisioner fix is merged upstream, and there is an upstream Rook PR to update to the latest lib here: https://github.com/rook/rook/pull/9529

Comment 5 Blaine Gardner 2022-01-11 18:42:26 UTC

Merged to 4.10 codebase here: https://github.com/red-hat-storage/rook/pull/326

Comment 8 Mugdha Soni 2022-02-01 08:41:58 UTC

Validated the fix with following versions :-

OCP :- 4.10.0-0.nightly-2022-01-31-012936

ODF :- 

[root@localhost odf-410]# oc get csv odf-operator.v4.10.0 -o yaml -n openshift-storage| grep full_version
    full_version: 4.10.0-122
          f:full_version: {}

---------------------------------------------------------------------------------------------------------------

Steps performed :-

1. Created an OBC named "analytics-data-sync--bucket".

[root@localhost odf-410]# oc get obc  --all-namespaces
NAMESPACE   NAME                          STORAGE-CLASS                 PHASE   AGE
default     analytics-data-sync--bucket   openshift-storage.noobaa.io   Bound   41s

2.The OBC was bounded , and the last char of the name should be truncated but i do-not see that.

Screenshot are attached here ;- https://docs.google.com/document/d/13frytUV-6S7O8ZbSxjE2a2h9mr3lRQ5GsvxsdZSVXj8/edit?usp=sharing

Please correct me if am wrong .

Thanks 
Mugdha Soni

Comment 9 Blaine Gardner 2022-02-02 16:55:08 UTC

I believe I misunderstood your initial post. Sorry about that. The name of the ObjectBucketClaim will not be truncated; however, the name of the generated bucket should be. It looks like Danny replied effectively here: https://bugzilla.redhat.com/show_bug.cgi?id=2030839#c10. The test should be the same for Rook as it is for noobaa (just a different storage class).

Comment 10 Blaine Gardner 2022-02-08 15:42:27 UTC

I think my last comment should have had the info you need, so clearning needinfo. Please always feel free to request again if that's not the case.

Comment 15 Blaine Gardner 2022-02-28 15:29:56 UTC

This validation looks correct to me. Thanks, @musoni

Comment 16 Mugdha Soni 2022-03-01 06:38:46 UTC

Based on comment#14 and comment#15 moving the bug to verified state .

Thankyou 
Mugdha Soni

Comment 18 errata-xmlrpc 2022-04-13 18:51:24 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Red Hat OpenShift Data Foundation 4.10.0 enhancement, security & bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:1372