Bug 2037565

By removing sdl12-compat, compiling sdl12 f34 branch for the f35 and installing it, tucnak works as expected.

While this probably does expose a bug in sdl12-compat (which is worth forwarding upstream), I see that libzia supports GTK3 and SDL2, can you try switching to that first?

It seems it works with SDL2, I will try switching in f35+.

Heads up, we've worked around this in sdl12-compat, so it should work out of the box now without switching libzia to the SDL2 target (but your eventual goal _should be_ to switch to the SDL2 target!).

The sdl12-compat bug report where the details are is located here:

https://github.com/libsdl-org/sdl12-compat/issues/182

The fix is already in our revision control, and we're about to finalize an official 1.2.54 release of sdl12-compat, so once that makes it into the world and the package gets updated, very soon, this bug should be resolved, too.

Sorry for the trouble!

--ryan.

(In reply to Ryan C. Gordon from comment #4)
> Heads up, we've worked around this in sdl12-compat, so it should work out of
> the box now without switching libzia to the SDL2 target (but your eventual
> goal _should be_ to switch to the SDL2 target!).
> 
> The sdl12-compat bug report where the details are is located here:
> 
> https://github.com/libsdl-org/sdl12-compat/issues/182
> 
> The fix is already in our revision control, and we're about to finalize an
> official 1.2.54 release of sdl12-compat, so once that makes it into the
> world and the package gets updated, very soon, this bug should be resolved,
> too.
> 
> Sorry for the trouble!
> 
> --ryan.

Great, thanks for info. We now have libzia on SDL2, but this fix could help other projects.

As noted in https://github.com/libsdl-org/sdl12-compat/issues/182
applying the following patch to libzia v4.35 or 4.36 fixes 24 bit
rendering when tucnak is run against sdl12-compat-1.2.56 which is
what fedora recently adopted.

diff -up  a/src/zsdl.c b/src/zsdl.c
--- a/src/zsdl.c
+++ a/src/zsdl.c
@@ -319,7 +319,7 @@ void z_putpixel24(SDL_Surface *surface, 
     Uint8  *p8;
 
     if (z_clip_pixel(&surface->clip_rect, x, y)) return;
-    p16 = (Uint16 *) surface->pixels + y*surface->pitch/3 + x;
+    p16 = (Uint16 *) ((Uint8 *)surface->pixels + y*surface->pitch + x*3);
     p8  = (Uint8 *)  (p16+1); 
     *p16 = color;     /* TODO Big endian? */
     *p8  = color>>16; 
@@ -354,7 +354,7 @@ void z_putpixel24inv(SDL_Surface *surfac
     Uint8  *p8;
 
     if (z_clip_pixel(&surface->clip_rect, x, y)) return;
-    p16 = (Uint16 *) surface->pixels + y*surface->pitch/3 + x;
+    p16 = (Uint16 *) ((Uint8 *)surface->pixels + y*surface->pitch + x*3);
     p8  = (Uint8 *)  (p16+1); 
     *p16 = ~color;     /* TODO Big endian? */
     *p8  = ~(color>>16);

(In reply to Ozkan Sezer from comment #6)

Thanks, I forwarded the patch to tucnak upstream.

FEDORA-2022-e4559c8ed0 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-e4559c8ed0

FEDORA-2022-9400b16a0a has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9400b16a0a

FEDORA-2022-4b844fbebe has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4b844fbebe

FEDORA-2022-e4559c8ed0 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-e4559c8ed0`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-e4559c8ed0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-4b844fbebe has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-4b844fbebe`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-4b844fbebe

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-9400b16a0a has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-9400b16a0a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-9400b16a0a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2022-4b844fbebe has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2022-9400b16a0a has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2022-e4559c8ed0 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.