Bug 2037648

Summary: upgrade check checking group ownership of /var/lib/pulp (pulp2) instead of /var/lib/pulp/content (pulp3)
Product: Red Hat Satellite Reporter: sganar
Component: Satellite MaintainAssignee: satellite6-bugs <satellite6-bugs>
Status: CLOSED ERRATA QA Contact: sganar
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.9.8CC: apatel, aupadhye, egolov, gtalreja, kgaikwad, pcreech
Target Milestone: 6.11.0Keywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rubygem-foreman_maintain-1.0.2 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-07-05 14:31:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description sganar 2022-01-06 08:53:20 UTC 
Description of problem:

satellite-maintain upgrade check is checking group ownership of "/var/lib/pulp"(pulp2) instead of "/var/lib/pulp/content"(pulp3)

Version-Release number of selected component (if applicable):
Satellite 6.9.8

How reproducible:
Always

Steps to Reproduce:
1. run satellite-maintain upgrade check --target-version 6.10
2.
3.

Actual results:
upgrade check is checking group ownership of "/var/lib/pulp" instead of "/var/lib/pulp/content"

Expected results:
upgrade check should check group ownership of "/var/lib/pulp/content" instead of "/var/lib/pulp"

Additional info:
During "foreman-maintain prep-6.10-upgrade" we are checking group ownership "/var/lib/pulp/content"(pulp3) which is as expected.

# foreman-maintain prep-6.10-upgrade
Running Preparations for the Satellite 6.10 upgrade
================================================================================
Preparations for the Satellite 6.10 upgrade:
prep-6.10-upgrade may take a while depending on the size of /var/lib/pulp/content
/ # chgrp -R pulp /var/lib/pulp/content                               [OK]
--------------------------------------------------------------------------------
Comment 1 Evgeni Golov 2022-01-11 15:00:09 UTC 
The check looks for /var/lib/pulp: https://github.com/theforeman/foreman_maintain/blob/master/definitions/checks/pulpcore/group_ownership_check.rb
The fix/prep-step only updates /var/lib/pulp/content: https://github.com/theforeman/foreman_maintain/blob/master/definitions/procedures/prep_6_10_upgrade.rb

They should use the same path :)
Comment 2 Bryan Kearney 2022-01-13 16:05:27 UTC 
Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/34231 has been resolved.
Comment 3 sganar 2022-02-09 10:12:36 UTC 
Verified.

Tested on Satellite 6.9.8 Snap 2.0
rubygem-foreman_maintain-1.0.2-1.el7sat.noarch

Steps followed: 

1. run satellite-maintain upgrade check --target-version 6.10

Observation: 
upgrade check checks the group ownership of "/var/lib/pulp/content" as expected.
Comment 6 errata-xmlrpc 2022-07-05 14:31:37 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Satellite 6.11 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5498