Bug 2038144

The commit here

https://src.fedoraproject.org/rpms/vttest/c/c8de6824184591546cc83889681e3aa3ea860d43?branch=rawhide

gives no clue regarding why it was retired.  Based on the packager's set of packages, it appears to have been disinterest, since it is unrelated to any of those.

The package is easily built, and I'm willing to maintain it.

I will review this package and sponsor you to Fedora.

> %define AppProgram vttest

Should be removed. Always use standard %{name} macro.

> %define AppVersion 2.7.%{AppPatched}

Always use standard %{version} macro.

> Release: 1

Missing %{?dist} tag:

Release: 1%{?dist}

> # no need for debugging symbols...
> %define debug_package %{nil}

Must be removed. All Fedora packages with ELF binaries must have automatically generated -debuginfo subpackages.

> %setup -q -n %{AppProgram}-%{AppPatched}

Can be simplified after fixing version and release:

%autosetup

> INSTALL_PROGRAM='${INSTALL}' \
> %configure \
>  --target %{_target_platform} \
>  --prefix=%{_prefix} \
>  --bindir=%{_bindir} \
>  --libdir=%{_libdir} \
>  --mandir=%{_mandir}

Should be simplified by %configure. All needed flags will be added automatically.

> [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT

Must be removed. Not allowed on Fedora.

> make install                    DESTDIR=$RPM_BUILD_ROOT

Should be replaced with %make_install.

> strip $RPM_BUILD_ROOT%{_bindir}/%{AppProgram}

Must be removed. Stripping will be performed automatically to the separate -debuginfo subpackage.

> %defattr(-,root,root)

Must be removed. Not allowed on Fedora.

> %{_prefix}/bin/%{AppProgram}

Must be replaced with:

%{_bindir}/%{name}

> %{_mandir}/man1/%{AppProgram}.*

%{_mandir}/man1/%{name}.*

> # each patch should add its ChangeLog entries here

Remove this entry.

Current version addresses this, except for %autosetup,
which doesn't work with the existing sources.

Perhaps it has some options to allow it to be used instead  of %setup.

> INSTALL_PROGRAM='${INSTALL}' \

Don't needed. Remove this.

> make

%make_build

> mkdir -p $RPM_BUILD_ROOT%{_docdir}/%{name}
> install -m 644 BUGS CHANGES MANIFEST README $RPM_BUILD_ROOT%{_docdir}/%{name}

Remove these and use in %files section:
%doc BUGS CHANGES MANIFEST README

> mkdir -p $RPM_BUILD_ROOT%{_licensedir}/%{name}
> install -m 644 COPYING $RPM_BUILD_ROOT%{_licensedir}/%{name}

Remove these and use in %files section:

%license COPYING

> %{_docdir}/%{name}
> %{_licensedir}/%{name}

Remove these. Will be automatically introduced.

done - thanks

> [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT

Not allowed on Fedora and must be removed.

Also please update your SRPM and SPEC.

removed the "rm -rf"

I don't understand the "please update" (where should I do that?)

> I don't understand the "please update" (where should I do that?)

You need to post links to the updated SPEC and SRPM.

> * Sat Jan 08 2022 Thomas E. Dickey

All changelog entries must be fully versioned.

Use this one and remove all others:

* Sat Jan 08 2022 Thomas E. Dickey <dickey> - 2.7.20210210-1
- address review-comments
- install doc, license files used in previous Fedora package

SPEC https://src.fedoraproject.org/fork/thomas-dickey/rpms/vttest/blob/rawhide/f/vttest.spec
https://invisible-mirror.net/archives/temp/REVIEW/vttest-2.7.20210210-1.fc36.src.rpm

SPEC link is incorrect. It must points to the text/plain file as required by the fedora-review tool.

Use this one: https://src.fedoraproject.org/fork/thomas-dickey/rpms/vttest/raw/rawhide/f/vttest.spec

SPEC https://src.fedoraproject.org/fork/thomas-dickey/rpms/vttest/raw/rawhide/f/vttest.spec
SRPM https://invisible-mirror.net/archives/temp/REVIEW/vttest-2.7.20210210-1.fc36.src.rpm

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

C/C++:
[x]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. No licenses found. Please check the source files for
     licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[!]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define AppPatched 20210210
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (debuginfo)
-------------------
Cannot parse rpmlint output:



Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
https://invisible-mirror.net/archives/vttest/vttest-20210210.tgz :
  CHECKSUM(SHA256) this package     : 0f98a2e305982915f1520984c3e8698e3acd508ee210711528c89f5a7ea7f046
  CHECKSUM(SHA256) upstream package : 0f98a2e305982915f1520984c3e8698e3acd508ee210711528c89f5a7ea7f046


Requires
--------
vttest (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    rtld(GNU_HASH)

vttest-debuginfo (rpmlib, GLIBC filtered):

vttest-debugsource (rpmlib, GLIBC filtered):



Provides
--------
vttest:
    vttest
    vttest(x86-64)

vttest-debuginfo:
    debuginfo(build-id)
    vttest-debuginfo
    vttest-debuginfo(x86-64)

vttest-debugsource:
    vttest-debugsource
    vttest-debugsource(x86-64)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 2038144
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, C/C++, Shell-api
Disabled plugins: Ocaml, fonts, SugarActivity, PHP, R, Java, Haskell, Perl, Python
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

> %define AppPatched 20210210

%global AppPatched 20210210

This minor issue can be fixed during importing package to the Fedora SCM.

Package approved.

thanks :-)