Bug 2038612

Summary: Review Request: rust-nu-protocol - Core values and protocols for Nushell
Product: [Fedora] Fedora Reporter: Michel Lind <michel>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-04-28 05:50:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1953940, 2038486, 2038505    
Bug Blocks: 2038632, 2038637, 2038638, 2038642, 2038648, 2038652, 2038653, 2038736, 2038790    

Description Michel Lind 2022-01-08 22:39:37 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust/rust-nu-protocol.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust/rust-nu-protocol-0.42.0-1.fc35.src.rpm
Description: Core values and protocols for Nushell.
Fedora Account System Username: salimma

Comment 1 Fabio Valentini 2022-01-21 20:46:16 UTC
Depends on nu-errors and nu-source, added bugs for those reviews as blockers.

Comment 3 Fabio Valentini 2022-04-14 18:39:12 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Please add a better description than "some tests fail" for why you disable some tests. :)

Comment 4 Michel Lind 2022-04-15 18:06:26 UTC
(In reply to Fabio Valentini from comment #3)

> Please add a better description than "some tests fail" for why you disable
> some tests. :)

Will do, thanks!

src/fedora/pkgs-sig-rust took 4s
❯ fedpkg request-repo rust-nu-protocol 2038612
https://pagure.io/releng/fedora-scm-requests/issue/43731

src/fedora/pkgs-sig-rust took 4s
❯ fedpkg request-branch --repo rust-nu-protocol --all-releases
https://pagure.io/releng/fedora-scm-requests/issue/43732
https://pagure.io/releng/fedora-scm-requests/issue/43733
https://pagure.io/releng/fedora-scm-requests/issue/43734

Comment 5 Gwyn Ciesla 2022-04-15 19:15:49 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nu-protocol

Comment 6 Fedora Update System 2022-04-18 21:29:16 UTC
FEDORA-2022-4f48ae2d1a has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4f48ae2d1a

Comment 7 Fedora Update System 2022-04-18 21:30:30 UTC
FEDORA-2022-40a68fac9c has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-40a68fac9c

Comment 8 Fedora Update System 2022-04-18 21:31:19 UTC
FEDORA-2022-43bd74ffd7 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-43bd74ffd7

Comment 9 Fedora Update System 2022-04-19 17:27:24 UTC
FEDORA-2022-4f48ae2d1a has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-4f48ae2d1a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-4f48ae2d1a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2022-04-20 20:24:52 UTC
FEDORA-2022-43bd74ffd7 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-43bd74ffd7 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-43bd74ffd7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2022-04-20 20:25:55 UTC
FEDORA-2022-40a68fac9c has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-40a68fac9c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-40a68fac9c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-04-28 05:50:30 UTC
FEDORA-2022-40a68fac9c has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2022-04-28 05:53:49 UTC
FEDORA-2022-43bd74ffd7 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2022-05-07 04:26:55 UTC
FEDORA-2022-4f48ae2d1a has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.