Bug 2038645

Summary:	Review Request: rust-common-path - Finds the common prefix between a set of paths
Product:	[Fedora] Fedora	Reporter:	Michel Lind <michel>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-10-14 11:52:21 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2038648

Description Michel Lind 2022-01-09 06:42:31 UTC

Spec URL: https://salimma.fedorapeople.org/specs/rust/rust-common-path.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust/rust-common-path-1.0.0-1.fc35.src.rpm
Description: Finds the common prefix between a set of paths.
Fedora Account System Username: salimma

Comment 1 Fabio Valentini 2022-01-10 14:48:36 UTC

Note that the rand dev-dependency is a little old, you might want to poke upstream about porting their tests from rand 0.6 to 0.8.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT or ASL 2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add package to rust-sig with "commit" access

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 2 Michel Lind 2022-01-10 23:26:01 UTC

(In reply to Fabio Valentini from comment #1)
> Note that the rand dev-dependency is a little old, you might want to poke
> upstream about porting their tests from rand 0.6 to 0.8.

I noticed the upstream hasn't released anything for a while, but it's even worse ... uh, the repo linked in crates.io is not there anymore.

I'll file a bug with nu-data flagging them that they have a dead upstream and see if they want to at least fork and host it, and try and contact the author directly. Ugh, they have new crates like faclair that is depended on optionally by serde (!!) that do not even have repos listed

Comment 3 Michel Lind 2022-01-10 23:26:14 UTC

$ fedpkg request-repo rust-common-path 2038645
https://pagure.io/releng/fedora-scm-requests/issue/40732

Comment 4 Gwyn Ciesla 2022-01-11 15:00:30 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-common-path

Comment 5 Michel Lind 2022-01-11 22:56:44 UTC

I notified the downstream (nu-data) that they have a dead upstream with no repo: https://github.com/nushell/nushell/issues/4250

Comment 6 Fabio Valentini 2022-10-14 11:52:21 UTC

This package has been imported and built long ago:
https://bodhi.fedoraproject.org/updates/FEDORA-2022-1dbbb0b790