Bug 2039187

Summary:	increasing the thread limits within a pod - PodPidsLimit
Product:	OpenShift Container Platform	Reporter:	Catherine_H <yhuang>
Component:	Node	Assignee:	Swarup Ghosh <swghosh>
Node sub component:	CRI-O	QA Contact:	Sunil Choudhary <schoudha>
Status:	CLOSED NOTABUG	Docs Contact:
Severity:	medium
Priority:	medium	CC:	aos-bugs, djohnsto, dseals, harpatil, joedward, jokerman, mchebbi, mfojtik, minmli, mmarkand, mmillson, oarribas, pehunt, rbost, rphillips, swghosh, weihuang, yhuang
Version:	4.8	Keywords:	Reopened
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1844447	Environment:
Last Closed:	2022-05-05 14:48:18 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1844447
Bug Blocks:

Comment 5 Dan Seals 2022-03-07 18:35:08 UTC

I have a case that is hitting this bug as well.
OCP 4.8.21
~~~
 - lastTransitionTime: "2022-02-23T19:37:42Z"
    message: 'Error: invalid PidsLimit -1'
    status: "False"
    type: Failure
~~~

Comment 8 Swarup Ghosh 2022-03-09 09:56:32 UTC

The PidsLimit in ContainerRuntimeConfig have undergone some changes since 4.8. As a contrary, the value of PidsLimit must be a number greater than 20 [1] for it to be valid. So, using "pidsLimit: -1" is not actually allowed.

However, it also does seem like there is no upper bound on this limit and setting a very high value should suffice the actual use cases in concern.

[1] https://github.com/openshift/machine-config-operator/blob/release-4.7/pkg/controller/container-runtime-config/helpers.go#L437-L439