Bug 2039197

Summary:	disable the obs metric collect should not impact the managed cluster upgrade
Product:	Red Hat Advanced Cluster Management for Kubernetes	Reporter:	Hui Chen <huichen>
Component:	Core Services / Observability	Assignee:	Chunlin Yang <chuyang>
Status:	CLOSED ERRATA	QA Contact:	Xiang Yin <xiyin>
Severity:	high	Docs Contact:
Priority:	high
Version:	rhacm-2.4.z	CC:	cqu, crizzo, dhuynh, juhsu, llan
Target Milestone:	---	Keywords:	Regression
Target Release:	rhacm-2.4.3	Flags:	bot-tracker-sync: rhacm-2.4.z+
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-04-20 23:47:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Hui Chen 2022-01-11 08:25:23 UTC

Description of the problem:

Currently, When I disable the obs metric collect by updating the mco CR, the obs addon status will changed to `Degraded` status, this will impact the managedcluster upgrade since if the cluster status was not ready on cluster list page, we can not upgrade the cluster to the new version.

the degraded status should be like, when the addon component has some problem and need admin to check before upgrade the cluster, But that should not mean we need to enable all of addon features and make sure they are worked. 

and we provide the way to disable the metric collect, that's means user can disable the metric collect in their environment and it should be a correct user behavior, so when the metric collect was disabled, I think we may not need to check the metric collect status any more as the addon status.

Release version:
ACM 2.4
Operator snapshot version:

OCP version:
OCP 4.6+
Browser Info:

Steps to reproduce:
1. update the mco CR by disable the metric collector
2. check the cluster on cluster list

Actual results:
the cluster will change to degrade status.

Expected results:
obs addon should not care about the metric collector addon since it was disable by admin/user already.

Additional info:

Comment 1 llan 2022-01-17 20:08:41 UTC

Currently the "Disabled" status will be translated to "Degraded" when we updating managedclusteraddon.
I agree to make "Dsiabled" mapped to "Available" but with the disable related message. Since the status is the addon status, I think "available" is reasonable for a disabled status since observabilityaddon still work well even it's disabled to push metrics. And user also can get the details in the message section.

Comment 2 bot-tracker-sync 2022-04-12 23:33:50 UTC

G2Bsync 1097256466 comment 
 dtthuynh Tue, 12 Apr 2022 21:48:41 UTC 
 G2Bsync  Re-tested on v2.4.3RC2.

with metrics enabled, I see the `observability-controller` addon in the managed cluster addons list. Even while its in Progressing state, the cluster shows as `Ready`. When `enableMetrics` is set to false, the addon disappears from the addon list and the cluster is in `Ready` state, with the option to upgrade and perform other actions on the cluster as necessary.

Comment 8 errata-xmlrpc 2022-04-20 23:47:32 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Red Hat Advanced Cluster Management 2.4.3 security updates and bug fixes), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:1476