Bug 2039245

Summary:	Review Request: perl-Syntax-Keyword-MultiSub - Multiple dispatch on subroutines
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Syntax-Keyword-MultiSub-0.02-1.fc36	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-01-18 11:34:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2033300
Bug Blocks:

Description Petr Pisar 2022-01-11 10:43:17 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Syntax-Keyword-MultiSub/perl-Syntax-Keyword-MultiSub.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Syntax-Keyword-MultiSub/perl-Syntax-Keyword-MultiSub-0.02-1.fc36.src.rpm
Description:
This module provides a new keyword, multi, to put before subroutine
declarations, which permits multiple distinct function bodies to be
provided, which take different parameters. A call to a multi sub will
invoke whichever function body best fits the arguments passed.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2022-01-13 12:58:23 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Syntax-Keyword-MultiSub-0.02-1.fc36.x86_64.rpm | sort | uniq -c | grep -v rpmlib
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.34)(64bit)
      1 perl(Carp)
      1 perl(:MODULE_COMPAT_5.34.0)
      1 perl(:VERSION) >= 5.14.0
      1 perl(warnings)
      1 perl(XSLoader)
      1 perl(XS::Parse::Sublike) >= 0.15
      1 perl(:XS_Parse_Sublike_ABI) = 4
      1 rtld(GNU_HASH)
$ rpm -qp --requires perl-Syntax-Keyword-MultiSub-tests-0.02-1.fc36.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(experimental)
      1 perl(feature)
      1 perl(Future)
      1 perl(Future::AsyncAwait) >= 0.55
      1 perl(Syntax::Keyword::MultiSub)
      1 perl-Syntax-Keyword-MultiSub = 0.02-1.fc36
      1 perl(Test::Fatal)
      1 perl-Test-Harness
      1 perl(Test::More) >= 0.88
      1 perl(:VERSION) >= 5.14.0
      1 perl(:VERSION) >= 5.26.0
      1 perl(warnings)
      1 /usr/bin/perl
      1 /usr/bin/sh
Binary requires are Ok.

$ rpm -qp --provides perl-Syntax-Keyword-MultiSub-0.02-1.fc36.x86_64.rpm | sort | uniq -c
      1 perl(Syntax::Keyword::MultiSub) = 0.02
      1 perl-Syntax-Keyword-MultiSub = 0.02-1.fc36
      1 perl-Syntax-Keyword-MultiSub(x86-64) = 0.02-1.fc36
$ rpm -qp --provides perl-Syntax-Keyword-MultiSub-tests-0.02-1.fc36.noarch.rpm | sort | uniq -c
      1 perl-Syntax-Keyword-MultiSub-tests = 0.02-1.fc36
Binary provides are Ok.

$ rpmlint ./perl-Syntax-Keyword-MultiSub*
perl-Syntax-Keyword-MultiSub-tests.noarch: W: no-documentation
2 packages and 1 specfiles checked; 0 errors, 1 warnings.
Rpmlint is ok

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
Approved

Comment 2 Petr Pisar 2022-01-13 13:58:39 UTC

https://pagure.io/releng/fedora-scm-requests/issue/40932

Comment 3 Gwyn Ciesla 2022-01-13 16:43:31 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Syntax-Keyword-MultiSub

Comment 4 Petr Pisar 2022-01-14 08:57:30 UTC

Thank you for the review and the repository.

Comment 5 Petr Pisar 2022-01-14 08:58:23 UTC

https://pagure.io/releng/fedora-scm-requests/issue/40948

Comment 6 Petr Pisar 2022-01-18 11:34:33 UTC

This package also requires perl(XS::Parse::Sublike) >= 0.15 which cannot be pushed into F35 because of an ABI change (bug #2033007). Hence I won't push perl-Syntax-Keyword-MultiSub into Fedora 35.