Bug 2039379

Summary:	Review Request: python-wcag-contrast-ratio - a library for computing contrast ratios
Product:	[Fedora] Fedora	Reporter:	Karolina Surma <ksurma>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mhroncok, package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-01-20 07:57:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Karolina Surma 2022-01-11 16:00:45 UTC

This is a small package that python-pygments recently started to depend on. We need it to bring the newest python-pygments update to Fedora.

Spec URL: https://download.copr.fedorainfracloud.org/results/ksurma/wcag-contrast-ratio/fedora-rawhide-x86_64/03141766-python-wcag-contrast-ratio/python-wcag-contrast-ratio.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/ksurma/wcag-contrast-ratio/fedora-rawhide-x86_64/03141766-python-wcag-contrast-ratio/python-wcag-contrast-ratio-0.9-1.fc36.src.rpm
Description: A library for computing contrast ratios, as required by WCAG 2.0.
Fedora Account System Username: ksurma

Comment 1 Zbigniew Jędrzejewski-Szmek 2022-01-12 08:02:10 UTC

+ package name is OK
+ latest version
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ builds and installs OK
+ BR/R/P look OK
+ pyproject macros are used, so there isn't really much to review

rpmlint:
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Package is APPROVED.

Comment 2 Miro Hrončok 2022-01-12 09:50:27 UTC

# Let our tox set the correct path to py.test
sed -i 's/{envbindir}\/py.test/py.test/g' tox.ini

This should also work in upstream. Consider proposing this change as well, please.

Comment 3 Karolina Surma 2022-01-12 10:48:02 UTC

(In reply to Miro Hrončok from comment #2)
> # Let our tox set the correct path to py.test
> sed -i 's/{envbindir}\/py.test/py.test/g' tox.ini
> 
> This should also work in upstream. Consider proposing this change as well,
> please.

Done, thank you for the remark.

Comment 4 Gwyn Ciesla 2022-01-12 14:52:45 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-wcag-contrast-ratio