Bug 2039954

Summary: Review Request: dlt-daemon - Diagnostic Log and Trace
Product: [Fedora] Fedora Reporter: Stephen John Smoogen <smooge>
Component: Package ReviewAssignee: Alexander Larsson <alexl>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: alexl, package-review, psabata
Target Milestone: ---Flags: alexl: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-02-23 15:01:39 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Stephen John Smoogen 2022-01-12 18:55:03 UTC
Spec URL: https://smooge.fedorapeople.org/automotive_sig_packages/dlt-daemon/SPECS/dlt-daemon.spec
SRPM URL: https://smooge.fedorapeople.org/automotive_sig_packages/dlt-daemon/SRPMS/dlt-daemon-2.18.8-1.fc35.src.rpm
Description: This component provides a standardised log and trace interface, based on the
standardised protocol specified in the AUTOSAR standard 4.0 DLT.
This component can be used by GENIVI components and other applications as
logging facility providing
Fedora Account System Username: smooge

Comment 1 Alexander Larsson 2022-02-22 15:01:04 UTC
I think this looks ok, but i did some changes to the config to make it more fedora-ish:

https://alexl.fedorapeople.org/dlt-daemon/dlt-daemon.spec

Changes:

* Tue Feb 22 2022 Alexander Larsson <alexl> - 2.18.8-2
- Marked config files
- Change config to store data in /var/lib/dlt-daemon instead of /tmp
- Store sockets in /run/dlt, not in /tmp
- Tweak source url to get better named source tarballs

Comment 2 Alexander Larsson 2022-02-22 15:28:59 UTC
Ran rpmlint on my package and got some conffile-without-noreplace-flag on /etc/dlt.conf, /etc/dlt_gateway.conf, /etc/dlt-system.conf. Maybe these should be %config(noreplace)?

Comment 3 Stephen John Smoogen 2022-02-22 18:50:17 UTC
I have updated the spec files and packages uploaded new ones to 
SRPM URL: https://smooge.fedorapeople.org/automotive_sig_packages/dlt-daemon/SRPMS/dlt-daemon-2.18.8-3.fc35.src.rpm

Thank you for the hints on what I needed to do make this a better package.

Comment 4 Stephen John Smoogen 2022-02-22 19:34:02 UTC
Built packages are in https://smooge.fedorapeople.org/automotive_sig_packages/dlt-daemon/RPMS/

Comment 5 Gwyn Ciesla 2022-02-23 14:31:17 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/dlt-daemon

Comment 6 Stephen John Smoogen 2022-02-23 15:01:39 UTC
Built as https://koji.fedoraproject.org/koji/taskinfo?taskID=83225032