Bug 2040529

Summary: The Machine-config-daemon prematurely marks pending updates as completed, leading to nodes never uncordoning if the sync times out
Product: OpenShift Container Platform Reporter: Yu Qi Zhang <jerzhang>
Component: Machine Config OperatorAssignee: Yu Qi Zhang <jerzhang>
Machine Config Operator sub component: Machine Config Operator QA Contact: Rio Liu <rioliu>
Status: CLOSED DUPLICATE Docs Contact:
Severity: high    
Priority: medium CC: arolivei, dornelas, fbergman, gmeghnag, jerzhang, jkyros, mateusz.bacal, mkrejci, rioliu, skumari, sregidor, wking, zzlotnik
Version: 4.7Keywords: Reopened
Target Milestone: ---Flags: rioliu: needinfo-
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 2039258 Environment:
Last Closed: 2022-10-17 16:22:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2015589    

Comment 6 Yu Qi Zhang 2022-02-22 17:57:09 UTC
*** Bug 2054792 has been marked as a duplicate of this bug. ***

Comment 14 Yu Qi Zhang 2022-08-02 21:47:33 UTC
Apologies for the delay. This BZ and https://bugzilla.redhat.com/show_bug.cgi?id=2015589 has been fixed as of 4.11:

1. The MCD no longer performs uncordons, and the new controller will always retry and has no issues with the pending config which can cause this.
2. The new controller should always be polling for the latest update, so this type of issue should generally not happen, minus API instability which we would otherwise have no control over

So I will be closing this once 4.11 ships. The rework which fixes this, however, is a pretty significant effort to backport. If we require this in earlier versions, we would likely need to apply another fix.

If you would like the corresponding fix backported, please state the reasoning and the version this needs backport to, and the team will prioritize accordingly. Otherwise this fix will be only in 4.11. Thank you.

Comment 15 Yu Qi Zhang 2022-10-17 16:22:53 UTC
Closing this as a duplicate. The underlying issue has been fixed

*** This bug has been marked as a duplicate of bug 2015589 ***