Bug 2040696

Summary: Review Request: golang-github-facebook-time - Facebook's NTP and PTP libraries
Product: [Fedora] Fedora Reporter: Alexander Bulimov <alexander.bulimov>
Component: Package ReviewAssignee: Davide Cavalca <davide>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: davide, package-review
Target Milestone: ---Flags: davide: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-01-07 17:45:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Alexander Bulimov 2022-01-14 14:44:36 UTC
Spec URL: https://abulimov.fedorapeople.org/review/golang-github-facebook-time.spec
SRPM URL: https://abulimov.fedorapeople.org/review/golang-github-facebook-time-0-0.5.20220113git83c4193.fc35.src.rpm
Description: This package is a collection of Facebook's NTP and PTP libraries. It
includes a protocol implementations for NTP, PTP, Chrony and ntpd, as well as high-performant NTP an PTP servers and various related tools.

This package replaces two existing packages: golang-github-facebookincubator-ntp and golang-github-facebookincubator-ptp, because those two github repos were merged into one: facebook/time.

Fedora Account System Username: abulimov

Comment 1 Davide Cavalca 2022-01-25 17:24:14 UTC
Taking this review

Comment 2 Davide Cavalca 2022-01-25 17:30:40 UTC
Package created with go2rpm, simplifying the review considerably.

 - License ok
 - Build in Mock
 - No rpmlint errors
 - Checks pass
 - Conforms to Packaging Guidelines

Package approved. Once this is imported and built, we'll want to retire the old packages.

Comment 3 Gwyn Ciesla 2022-01-26 15:17:36 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-facebook-time

Comment 4 Package Review 2023-01-07 17:45:36 UTC
Package is now in repositories, closing review.