Bug 2041189

Summary: Consider enabling the `module-roc-source` and `module-roc-sink` modules (ROC Toolkit)
Product: [Fedora] Fedora Reporter: Jonathan Watt <jwatt>
Component: pipewireAssignee: Wim Taymans <wtaymans>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 36CC: brunovern.a, joepesco2020, jskarvad, tomodachi, wtaymans
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pipewire-0.3.59-3.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-10-24 15:28:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2122395    
Bug Blocks:    
Attachments:
Description Flags
Roc enablement patch none

Description Jonathan Watt 2022-01-16 11:42:34 UTC 
The `module-roc-source` and `module-roc-sink` modules were added to Pipewire for 0.3.31:

https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/793

They aren't present in the Pipewire 0.3.40 that ships with Fedora 35. From a quick skim of the commits in the above pull request it seems likely that's because the ROC libraries are not installed on the machines that build Pipewire.

I've no idea what the prospects of the ROC Toolkit being packaged for Fedora are, but regardless of that would it be possible to have `module-roc-source` and `module-roc-sink` built and included with Fedora's Pipewire?
Comment 1 Ben Cotton 2022-02-08 21:11:16 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 36 development cycle.
Changing version to 36.
Comment 2 Mateusz Mojsiejuk 2022-07-11 18:31:14 UTC 
The pipewire version in Fedora 36 is 03.54

According to the upstream documentation for pipewire version 0.3.54
https://docs.pipewire.org/page_module_roc_source.html

It's available and enabled so I second OP:s comment it should be enabled / included in Fedora
to allow network audio streaming
Comment 3 Wim Taymans 2022-07-12 08:50:55 UTC 
It would depend on the roc toolkit (https://roc-streaming.org/) being packaged in fedora first.
Comment 4 Jaroslav Škarvada 2022-08-19 23:12:38 UTC 
(In reply to Wim Taymans from comment #3)
> It would depend on the roc toolkit (https://roc-streaming.org/) being
> packaged in fedora first.

I think I could package it. I haven't checked it thoroughly, but I think the roc toolkit is OK for Fedora (i.e. good license, no patents), please correct me if I am wrong.
Comment 5 Jaroslav Škarvada 2022-08-25 19:28:58 UTC 
FYI openfec (roc-toolkit requirement) review request bug 2121558. The roc-toolkit request will follow.
Comment 6 Jaroslav Škarvada 2022-08-29 22:59:19 UTC 
And the roc-toolkit review request bug 2122395. Reviewers are highly welcome.
Comment 7 Jaroslav Škarvada 2022-08-29 23:21:30 UTC 
Created attachment 1908423 [details]
Roc enablement patch
Comment 8 Jaroslav Škarvada 2022-10-11 13:10:06 UTC 
roc-toolkit is now in rawhide, pipewire PR enabling the support:
https://src.fedoraproject.org/rpms/pipewire/pull-request/11

Also please consider enabling the support in older releases as well (e.g. f36 and up), roc-toolkit bodhi updates are on the way.
Comment 9 Fedora Update System 2022-10-24 15:26:11 UTC 
FEDORA-2022-cc81b8ea12 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-cc81b8ea12
Comment 10 Fedora Update System 2022-10-24 15:28:36 UTC 
FEDORA-2022-cc81b8ea12 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.