Bug 2041605

Summary: Dynamic Plugins: discrepancy in proxy alias documentation/implementation
Product: OpenShift Container Platform Reporter: Kevin Cormier <kcormier>
Component: Management ConsoleAssignee: Jakub Hadvig <jhadvig>
Status: CLOSED ERRATA QA Contact: Yadan Pei <yapei>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.10CC: aos-bugs, yapei
Target Milestone: ---   
Target Release: 4.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-03-10 16:40:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Kevin Cormier 2022-01-17 20:21:40 UTC 
Description of problem:

From the enhancement (https://github.com/openshift/enhancements/blob/master/enhancements/console/dynamic-plugins.md#delivering-plugins), path of the alias should be:

/api/proxy/plugin/<plugin-name>/<proxy-alias>

However, in the implementation, the 'plugin' segment is omitted:

I0117 19:14:07.200071       1 server.go:482] The following console endpoints are now proxied to these services:
I0117 19:14:07.200099       1 server.go:485]  - /api/proxy/acm-plugin/console/ -> https://console-chart-6bc1d-console-v2.open-cluster-management.svc.cluster.local:3000

Version-Release number of selected component (if applicable):

OpenShift 4.10.0-0.nightly-2022-01-17

How reproducible:

Always

Steps to Reproduce:
1. Create a ConsolePlugin with a proxy service
2. Check logs for openshift-console pods

Actual results:

Actual proxied path does not include 'plugin' segment, but instead looks like /api/proxy/<plugin-name>/<proxy-alias>

Expected results:

Documentation and implementation should match

Additional info:
Comment 2 Jakub Hadvig 2022-01-18 17:04:55 UTC 
Putting back to ASSIGNED since we need to merge https://github.com/openshift/console-operator/pull/628 as part of the fix.
Comment 5 Yadan Pei 2022-01-24 03:43:57 UTC 
1. build a dynamic plugin based on https://github.com/yapei/console/tree/consoleplugin which has 
const ExampleProxyResponse: React.FC = () => {
  const [data, setData] = React.useState();

  React.useEffect(() => {
    consoleFetchJSON('/api/proxy/plugin/console-demo-plugin/demoplugin/api/v1/rules')
      .then((response) => {
        setData(response);
      })
      .catch((e) => console.error(e));
  }, []);

  return (
    <pre>{JSON.stringify(data, null, 2)}</pre>
  );
};
https://github.com/yapei/console/blob/consoleplugin/dynamic-demo-plugin/src/components/ExampleProxyPage.tsx#L41~L47 
2. create plugin manifests and enable dynamic plugin, visit /test-proxy-service, json is returned correctly

verified on 4.10.0-0.nightly-2022-01-22-102609
Comment 8 errata-xmlrpc 2022-03-10 16:40:08 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056