Bug 204166

I note a typo in the URL:; s/treaser/teaser/.

I'm not sure how you can say that the ROMs are not a problem.  Unless you can
prove that the copyright has expired or has been relinquished to the public
domain, I don't think you have any redistribution permission.  This would seem
to be a rather significant issue.

For reference, here is the relevant statement from the README file:

LEGAL
    atmos.rom, microdisc.rom and oric1.rom are copyright 1983 Tangerine.
    Tangerine is defunct. We don't know who the current assignee of the
    copyright is (if any).

    hyperbasic.rom, teleass.rom, telematic.rom and telemon-2.4.rom are
    copyright Oric International. Oric International is defunct. We
    don't know who the current assignee of the copyright is (if any).

    jasmin.rom is copyright Technologie Recherche et Applications
    Nouvelles. As far as I know, T.R.A.N. doesn't exist anymore. We
    don't know who the current assignee of the copyright is (if any).

I've looked further into this and according to companies house in the UK, every
company who had any rights to the ROMS have vanished with no successor in name
or title.

Of course, if it's a big problem, I'll package the ROMS in the same way as I did
for fuse-emulator to keep things clean.

All of these entities have been legally defunct for almost twenty years
(Tangerine Computer Systems is Oric International, died in 1988, no one
purchased their assets.) I'm lifting the legal hold on this one, but I'd advise
you to put the ROMS in a subpackage, in the unlikely event that a copyright
holder emerges from the depths. Also, they're being openly distributed by
another high-profile site (oric.org), so there is no risk here. Lifting FE-LEGAL.

New SRPMS and SPEC file (creates the roms subpackage)

SPEC : http://nodoid.homelinux.org/fedora/xeuphoric.spec
SRPM : http://nodoid.homelinux.org/fedora/xeuphoric-0.18.2-3.src.rpm

That typo in the URL is still there.

rpmlint has some complaints:
W: xeuphoric file-not-utf8 /usr/share/man/man1/xeuphoric.1.gz
   Indeed it isn't, probably due to a single character in the author's name.
W: xeuphoric non-conffile-in-etc /etc/xeuphoric/0.18.2/xeuphoricrc
   This needs to be marked %config.
E: xeuphoric configure-without-libdir-spec
   This is bogus; the configure script was not generated by autotools.
W: xeuphoric-roms no-documentation
   Not a problem.

So two valid complaints there.

The flags passed to the compiler seem to be "-DX11 -g -Wall -O3", which are
incorrect.  This is fixable by changing the make line to:
   make CFLAGS="-DX11 %{optflags}" %{?_smp_mflags}
The resulting executable seems to work fine.

I wonder if the base package shouldn't require the roms package, instead of the
other way around.  Normally you'd just install xeuphoric and have it pull in the
roms; currently if you do that you get something that doesn't work too well.

Review:
* source files match upstream:
   4a2469ee45d6476350ffc0a92d165990  xeuphoric-0.18.2.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
X compiler flags are not appropriate.
* %clean is present.
* package builds in mock (development, i386).
* package installs properly
* debuginfo package looks complete.
X rpmlint has valid complaints.
? final provides and requires are sane:
  xeuphoric-0.18.2-3.fc5.i386.rpm
   xeuphoric = 0.18.2-3.fc5
  =
   libX11.so.6
   libXext.so.6
   libartsc.so.0

  xeuphoric-roms-0.18.2-3.fc5.i386.rpm
   xeuphoric-roms = 0.18.2-3.fc5
  =
   xeuphoric = 0.18.2-3.fc5

* %check is not present; no test suite upstream.  Package manually tested and
found to be OK.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
X GUI app, but no desktop file.

SPEC : http://nodoid.homelinux.org/fedora/xeuphoric.spec
SRPM : http://nodoid.homelinux.org/fedora/xeuphoric-0.18.2-4.src.rpm

Done the bits you've said. Now has a desktop file and desktop file icon.
Added R xeuphoric-roms to the main package
Sorted the makefile and config file problems

I've not sorted the UTF-8 error in the man file as it's the guy's name and if it
needs a foreign character to be correct, then a foreign character it is.

Foreign characters are fine; that's what UTF-8 is for, after all.  But the point
is that documents must be legal UTF-8, and the manpage isn't because it includes
a character that is not properly encoded.  To fix it, you just need to make that
iconv call on docsrc/xeuphoric.1 instead of doc/xeuphoric.1 and everything
should be fine.

Everthing else about the package looks fine now, so just make that one change
and go ahead and check it in.

APPROVED

Thanks and imported :-)

Package Change Request
======================
Package Name: xeuphoric
Updated Fedora Owners: packages,paul.uk

The current maintainer (paul.uk) has given me his permission
to take ownership of this package as he is unable to maintain it at the moment
for personal reasons. I would like Paul to remain as co-maintainer in case he
wishes to continue with the package in the future.

cvs done.