Bug 2042036

Summary: [IBMCLOUD] "openshift-install explain installconfig.platform.ibmcloud" contains not yet supported custom vpc parameters
Product: OpenShift Container Platform Reporter: Pedro Amoedo <pamoedom>
Component: InstallerAssignee: aos-install
Installer sub component: openshift-installer QA Contact: Pedro Amoedo <pamoedom>
Status: CLOSED ERRATA Docs Contact:
Severity: medium    
Priority: unspecified CC: jnowicki
Version: 4.10   
Target Milestone: ---   
Target Release: 4.10.0   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-03-12 04:41:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Pedro Amoedo 2022-01-18 17:51:36 UTC
Version:

./openshift-install version
./openshift-install 4.10.0-fc.1
built from commit 130a5673f2a431ca96e603d55be7c8865a1b0849
release image quay.io/openshift-release-dev/ocp-release@sha256:9f3ac86ba907abba3ffbae580433218eef3f1934c3353caf331587ac7c450ff0
release architecture amd64

Platform:

IPI IBMCloud

What happened?

The command "openshift-install explain installconfig.platform.ibmcloud" contains unsupported parameters for custom VPC like "subnets","vpc" and "vpcResourceGroupName", those parameters are not yet implemented for 4.10:

~~~
./openshift-install explain installconfig.platform.ibmcloud
KIND:     InstallConfig
VERSION:  v1

RESOURCE: <object>
  IBMCloud is the configuration used when installing on IBM Cloud.

FIELDS:
    defaultMachinePlatform <object>
      DefaultMachinePlatform is the default configuration used when installing on IBM Cloud for machine pools which do not define their own platform configuration.

    region <string> -required-
      Region specifies the IBM Cloud region where the cluster will be created.

    resourceGroupName <string>
      ResourceGroupName is the name of an already existing resource group where the cluster should be installed. This resource group should only be used for this specific cluster and the cluster components will assume ownership of all resources in the resource group. Destroying the cluster using installer will delete this resource group. 
 This resource group must be empty with no other resources when trying to use it for creating a cluster. If empty, a new resource group will be created for the cluster.

    subnets <[]string>
      Subnets is a list of existing subnet IDs. Leave unset and the installer will create new subnets in the VPC network on your behalf.

    vpc <string>
      VPC is the ID of an existing VPC network. Leave unset and the installer will create a new VPC network on your behalf.

    vpcResourceGroupName <string>
      VPCResourceGroupName specifies the resource group containing an existing VPC. This must be defined if `VPC` is defined.
~~~

What did you expect to happen?

That those parameters that are not yet supported are not shown.

How to reproduce it (as minimally and precisely as possible)?

./openshift-install explain installconfig.platform.ibmcloud

Anything else we need to know?

Extra parameter "resourceGroupName", despite is not being prompted by the installer, it's already supported for 4.10.

Comment 2 Jeff Nowicki 2022-01-23 18:03:32 UTC
The only supported 'existing resource' for 4.10 is a resource group. The additional existing resource options for vpc and subnets will be a future release consideration. Those options will be removed as options at this time. How soon those options can be supported will be a prioritization activity based on other considerations and available resources.

Comment 3 Pedro Amoedo 2022-01-28 14:15:04 UTC
[QA Summary]

With latest changes from openshift/installer#5568[1], the results are now as expected and the options no longer visible nor accepted by the installer:

~~~
$ ./openshift-install-local version
./openshift-install-local unreleased-master-5524-g55a9f62e2693962bd4340917efded7407570d95a
built from commit 55a9f62e2693962bd4340917efded7407570d95a
release image registry.ci.openshift.org/origin/release:4.10
release architecture amd64

$ ./openshift-install-local explain installconfig.platform.ibmcloud
KIND:     InstallConfig
VERSION:  v1

RESOURCE: <object>
  IBMCloud is the configuration used when installing on IBM Cloud.

FIELDS:
    defaultMachinePlatform <object>
      DefaultMachinePlatform is the default configuration used when installing on IBM Cloud for machine pools which do not define their own platform configuration.

    region <string> -required-
      Region specifies the IBM Cloud region where the cluster will be created.

    resourceGroupName <string>
      ResourceGroupName is the name of an already existing resource group where the cluster should be installed. This resource group should only be used for this specific cluster and the cluster components will assume ownership of all resources in the resource group. Destroying the cluster using installer will delete this resource group. 
 This resource group must be empty with no other resources when trying to use it for creating a cluster. If empty, a new resource group will be created for the cluster.

$ ./openshift-install-local create manifests --dir test52/
FATAL failed to fetch Master Machines: failed to load asset "Install Config": failed to unmarshal install-config.yaml: failed to parse first occurence of unknown field: error unmarshaling JSON: while decoding JSON: json: unknown field "subnets"

$ ./openshift-install-local create manifests --dir test52/
FATAL failed to fetch Master Machines: failed to load asset "Install Config": failed to unmarshal install-config.yaml: failed to parse first occurence of unknown field: error unmarshaling JSON: while decoding JSON: json: unknown field "vpc"

$ ./openshift-install-local create manifests --dir test52/
FATAL failed to fetch Master Machines: failed to load asset "Install Config": failed to unmarshal install-config.yaml: failed to parse first occurence of unknown field: error unmarshaling JSON: while decoding JSON: json: unknown field "vpcResourceGroupName"
~~~

*** PASSED ***

[1] - https://github.com/openshift/installer/pull/5568

Best Regards.

Comment 6 errata-xmlrpc 2022-03-12 04:41:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056